-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Minor documentation refactoring on the new changelog process. #2162
Merged
marcosuma
merged 6 commits into
master
from
CLOUDP-243940-improve-changelog-process-error-language
Apr 18, 2024
Merged
chore: Minor documentation refactoring on the new changelog process. #2162
marcosuma
merged 6 commits into
master
from
CLOUDP-243940-improve-changelog-process-error-language
Apr 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosuma
changed the title
chore: Minor documentation refactoring on the new changelog process.
fix: Minor documentation refactoring on the new changelog process.
Apr 17, 2024
marcosuma
changed the title
fix: Minor documentation refactoring on the new changelog process.
chore: Minor documentation refactoring on the new changelog process.
Apr 17, 2024
Now error is printed like this:
|
I personally prefer to have the error detail (errFile) at the end of the message. It's normally additional info that you may not need, and I think we can get a clearer message. |
marcosuma
commented
Apr 17, 2024
lantoli
approved these changes
Apr 17, 2024
oarbusi
approved these changes
Apr 17, 2024
lantoli
approved these changes
Apr 17, 2024
AgustinBettati
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
marcosuma
deleted the
CLOUDP-243940-improve-changelog-process-error-language
branch
April 18, 2024 04:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the fix/feature/change, including any relevant motivation and context.
Link to any related issue(s): https://jira.mongodb.org/browse/CLOUDP-243940
Type of change:
Required Checklist:
Further comments