-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Refactor release steps ensuring tag is created before running tests and creating release #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgustinBettati
force-pushed
the
CLOUDP-242972
branch
from
April 16, 2024 09:31
1797621
to
5bc5dba
Compare
lantoli
reviewed
Apr 17, 2024
lantoli
reviewed
Apr 17, 2024
lantoli
reviewed
Apr 17, 2024
lantoli
reviewed
Apr 17, 2024
lantoli
reviewed
Apr 17, 2024
lantoli
reviewed
Apr 17, 2024
lantoli
reviewed
Apr 17, 2024
lantoli
approved these changes
Apr 17, 2024
lantoli
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lantoli
reviewed
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to any related issue(s): CLOUDP-242972
Release process steps now prioritises creating a release tag as soon as all quick validations and automatic commits are made. New order of steps:
Within 30 seconds the new tag is created, following steps for running acceptance tests and creating the release use the created tag. This ensures any new merges to master do not impact an ongoing release process.
Testing
Type of change:
Required Checklist:
Further comments