Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Leverages next-terraform-provider-release version #2149

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Apr 15, 2024

Description

Leverages next-terraform-provider-release fix version.

All Done (Closed or Resolved) tickets are move from next-terraform-provider-release to the release version during the Release workflow.

Link to any related issue(s): CLOUDP-214955

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

Example of output:

Issues moved: CLOUDP-237012, CLOUDP-237011
Version released, please check all tickets are marked as done: https://jira.mongodb.org/projects/CLOUDP/versions/39057

@lantoli lantoli marked this pull request as ready for review April 15, 2024 16:21
@lantoli lantoli requested a review from a team as a code owner April 15, 2024 16:21
@github-actions github-actions bot added the bug label Apr 15, 2024
@lantoli lantoli removed the bug label Apr 15, 2024
@github-actions github-actions bot added the bug label Apr 15, 2024
@lantoli lantoli changed the title chore: Leverages next-terraform-provider-release fix version chore: Leverages next-terraform-provider-release version Apr 15, 2024
@github-actions github-actions bot removed the bug label Apr 15, 2024
Copy link
Member

@AgustinBettati AgustinBettati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -51,18 +53,59 @@ func getVersion() string {
}

func getVersionID(client *jira.Client, versionName string) string {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func getVersionID(client *jira.Client, versionName string) string {
func getOrCreateVersionID(client *jira.Client, versionName string) string {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed, thx

projectKey = "CLOUDP"
jiraURL = "https://jira.mongodb.org"
versionPrefix = "terraform-provider-"
versionNameNext = "next-terraform-provider-release"
)

func main() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[q] Curious if we were able to test this in any way, or if we will wait for a proper release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i tested with a fake version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding an example of output in PR description

@lantoli lantoli merged commit 6c7e1d5 into master Apr 16, 2024
48 checks passed
@lantoli lantoli deleted the CLOUDP-214955_jira branch April 16, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants