-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update examples link during release process #2148
Conversation
d6fb86d
to
e9ecc17
Compare
type: string | ||
|
||
jobs: | ||
run_script_and_commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extracted this as it will also contain logic for commit signing and configuring github PAT.
NEW_URL="\[example configurations\](https:\/\/github.com\/mongodb\/terraform-provider-mongodbatlas\/tree\/$RELEASE_TAG\/examples)" | ||
|
||
|
||
TMP_FILE_NAME="docs.tmp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] Curious why we are not using "in-place" (-I
flag)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went for this approach initially but the implementation of sed in macOS vs Linux handles the -i
parameter differently. Opted for having same behaviour in CI vs running locally by simplifying how the command is invoked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT 👍
Description
Link to any related issue(s): CLOUDP-238066
Adds new step in release workflow to update how we reference the examples section from our terraform index page documentation.
Testing
Type of change:
Required Checklist:
Further comments