Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reuses project in tests - project_ip_access_list #2067

Merged
merged 17 commits into from
Mar 25, 2024

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Mar 22, 2024

Description

Reuses project in tests - project_ip_access_list.

Runs all tests in parallel, project test group now takes around 5 minutes instead of 15.

Link to any related issue(s): CLOUDP-239218

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@@ -190,132 +190,3 @@ func TestMigProjectRS_withLimits(t *testing.T) {
},
})
}

func TestMigProjectRSProjectIPAccesslist_withSettingIPAddress(t *testing.T) {
Copy link
Member Author

@lantoli lantoli Mar 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests were duplicated and in the wrong resource folder

@lantoli lantoli marked this pull request as ready for review March 25, 2024 07:00
@lantoli lantoli requested a review from a team as a code owner March 25, 2024 07:00
Copy link
Collaborator

@oarbusi oarbusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lantoli lantoli merged commit 13e4c80 into master Mar 25, 2024
47 checks passed
@lantoli lantoli deleted the CLOUDP-239218_project_ip_access_list branch March 25, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants