Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allows user to specify to use an existing tag for release #2053

Merged
merged 3 commits into from
Mar 22, 2024
Merged

feat: Allows user to specify to use an existing tag for release #2053

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f045eb
update release to use existing tag if required
maastha Mar 20, 2024
18a0157
address PR comments
maastha Mar 21, 2024
66dcd02
address PR comments
maastha Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ on:
required: true
skip_tests:
description: 'Skip QA acceptance tests, define value to `true` to explicitly skip'
use_existing_tag:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a small note in our release documentation on when this scenario could be useful or comes into picture?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

description: 'Set value to `true` to use an existing tag for this release version, default is `false`'

jobs:

Expand All @@ -28,6 +30,7 @@ jobs:
uses: ./.github/workflows/acceptance-tests.yml
with:
atlas_cloud_env: "qa"
ref: ${{ inputs.use_existing_tag == 'true' && inputs.version_number }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ref: ${{ inputs.use_existing_tag == 'true' && inputs.version_number }}
ref: ${{ inputs.use_existing_tag == 'true' && inputs.version_number || github.ref }}


release:
runs-on: ubuntu-latest
Expand All @@ -36,14 +39,17 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633
with:
ref: ${{ inputs.use_existing_tag == 'true' && inputs.version_number || github.ref }}
- name: Unshallow
run: git fetch --prune --unshallow
- name: Create release tag
uses: rickstaa/action-create-tag@a1c7777fcb2fee4f19b0f283ba888afa11678b72 # will fail if existing tag is present
uses: rickstaa/action-create-tag@a1c7777fcb2fee4f19b0f283ba888afa11678b72
with:
tag: ${{ inputs.version_number }}
gpg_private_key: ${{ secrets.GPG_PRIVATE_KEY }}
gpg_passphrase: ${{ secrets.PASSPHRASE }}
tag_exists_error: ${{ inputs.use_existing_tag == 'true' && false || true }}
maastha marked this conversation as resolved.
Show resolved Hide resolved
- name: Set up Go
uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491
with:
Expand Down