-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fixes search_deployment
template to fix doc structure
#1943
Conversation
search_deployment
template to fix doc structuresearch_deployment
template to fix doc structure
Subcategories were not used in any resource before using it in this resource. Changing it back to avoid wrong docs structure issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small comment. Great catch 💯
@@ -1,7 +1,7 @@ | |||
--- | |||
layout: "mongodbatlas" | |||
page_title: "MongoDB Atlas: {{.Name}}" | |||
subcategory: "docs_{{ .Name }}_{{.Type | lower}}" | |||
sidebar_current: "docs-{{ .ProviderShortName }}-{{ .Type | lower }}-{{ $name := split .Name "_" }}{{ index $name 1 }}-{{ index $name 2 }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I updated the 2 templates. I also changed a bit how it works so it's more generic and would work for all resources even if the resource name has a different amount of words than search_deployment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for all the changes here
I don't know if the link in make website can help to preview the changes here: https://registry.terraform.io/tools/doc-preview |
Thanks for sharing the link! I am adding it to our CONTRIBUTING.md in #1945 |
@lantoli tried it but it doesn't allow to preview the structure of all the docs, which in this case was the issue |
Description
Terraform registry docs for mongodbatlas are displayed with a wrong structure since v1.15.0 was released. The issue can be seen in the following image:
Link to any related issue(s):
Type of change:
Required Checklist:
Further comments