Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrades privatelink_endpoint_service_serverless resource to auto-generated SDK #1932

Merged
merged 10 commits into from
Feb 12, 2024
Merged

chore: Upgrades privatelink_endpoint_service_serverless resource to auto-generated SDK #1932

merged 10 commits into from
Feb 12, 2024

Conversation

oarbusi
Copy link
Collaborator

@oarbusi oarbusi commented Feb 9, 2024

Description

Upgrades privatelink_endpoint_service_serverless resource to auto-generated SDK
Add migration test

Link to any related issue(s): CLOUDP-226089

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

oarbusi
oarbusi commented Feb 9, 2024
View reviewed changes
...privatelinkendpointserviceserverless/data_source_privatelink_endpoints_service_serverless.go
projectID := d.Get("project_id").(string)
instanceName := d.Get("instance_name").(string)

options := &matlas.ListOptions{
Copy link
Collaborator Author

@oarbusi oarbusi Feb 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more need of pagination options, endpoint called by new SDK returns all serverless private endpoints

@oarbusi oarbusi marked this pull request as ready for review February 9, 2024 16:01
@oarbusi oarbusi requested a review from a team as a code owner February 9, 2024 16:01
andreaangiolillo
andreaangiolillo approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oarbusi oarbusi merged commit d5c7ea8 into master Feb 12, 2024
42 checks passed
@oarbusi oarbusi deleted the CLOUDP-226089 branch February 12, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantoli lantoli lantoli approved these changes

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oarbusi @lantoli @andreaangiolillo