chore: Improves Update Atlas SDK cache issues #1922
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -17,9 +17,12 @@ | |||||
| set -euo pipefail | ||||||
|
|
||||||
| LATEST_SDK_TAG=$(curl -sSfL -X GET https://api.github.com/repos/mongodb/atlas-sdk-go/releases/latest | jq -r '.tag_name') | ||||||
| LATEST_SDK_RELEASE=$(echo "${LATEST_SDK_TAG}" | cut -d '.' -f 1) | ||||||
|
|
||||||
| echo "==> Updating SDK to latest major version tag: ${LATEST_SDK_TAG}, release: ${LATEST_SDK_RELEASE}" | ||||||
| curl -sSfL -X GET "https://proxy.golang.org/go.mongodb.org/atlas-sdk/${LATEST_SDK_RELEASE}/@v/${LATEST_SDK_TAG}.info" | ||||||
|
There was a problem hiding this comment. FYI this may trigger the go proxy to do a fetch but it happens in the background so the next step may still fail
lantoli marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| GOPROXY=direct | ||||||
|
There was a problem hiding this comment.
Suggested change
There was a problem hiding this comment. pick an approach, skipping the proxy or asking the proxy to update There was a problem hiding this comment. WDYT about the latest version, i go for skipping proxy, but at the end asking the proxy to update so it'll benefit others edit: i'm going to go to ask update because skipping proxy is failing, e.g.: https://github.com/mongodb/terraform-provider-mongodbatlas/actions/runs/7820266017/job/21334559930 |
||||||
| echo "Using GOPROXY: $GOPROXY" | ||||||
| gomajor get "go.mongodb.org/atlas-sdk/${LATEST_SDK_RELEASE}@${LATEST_SDK_TAG}" | ||||||
| go mod tidy | ||||||
| echo "Done" | ||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you clarify what was the issue and how the improvement should help with? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as an example a new Atlas Go SDK version was released this morning, but it took many hours until the script was successful because Go caches. We want to try to avoid/minimize that delay