Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updates alert_configuration resource with new SDK #1851

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Jan 18, 2024

Description

Updates alert_configuration resource with new SDK.

  • Testing improved
  • Checked read-only fields: Created, GroupId, Id, Updated, Links (not used)

Link to any related issue(s): https://jira.mongodb.org/browse/CLOUDP-222708

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

@lantoli lantoli marked this pull request as ready for review January 18, 2024 09:05
@lantoli lantoli requested a review from a team as a code owner January 18, 2024 09:05
Copy link
Collaborator

@maastha maastha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: fix PR description
otherwise LGTM

@lantoli lantoli merged commit 25b070d into master Jan 18, 2024
41 checks passed
@lantoli lantoli deleted the CLOUDP-222708_alert_configuration branch January 18, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants