Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #171: added validation to avoid nil type error #173

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Fix #171: added validation to avoid nil type error #173

merged 2 commits into from
Mar 18, 2020

Conversation

PacoDw
Copy link
Contributor

@PacoDw PacoDw commented Mar 13, 2020

closes #171

@ghost ghost added the size/S label Mar 13, 2020
marinsalinas
marinsalinas approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@marinsalinas marinsalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PacoDw PacoDw mentioned this pull request Mar 13, 2020
Closed
themantissa
themantissa approved these changes Mar 13, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the quick fix on the crash report!

@themantissa
Copy link
Collaborator

@PacoDw are you waiting to merge for a reason? If not it's good to go.

@PacoDw
Copy link
Contributor Author

PacoDw commented Mar 18, 2020

Thanks @themantissa :)

@PacoDw PacoDw merged commit bf0ccd1 into master Mar 18, 2020
@PacoDw PacoDw deleted the fix-#171 branch March 18, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themantissa themantissa themantissa approved these changes

@marinsalinas marinsalinas marinsalinas approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TERRAFORM CRASH on importing mongodbatlas_alert_configuration
3 participants
@PacoDw @themantissa @marinsalinas