Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixes GH actions Update Atlas Go SDK #1671

Closed
wants to merge 1 commit into from
Closed

chore: Fixes GH actions Update Atlas Go SDK #1671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/update-sdk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ jobs:
if: steps.verify-changed-files.outputs.files_changed == 'true'
with:
title: "chore: Updates Atlas Go SDK"
token: ${{ secrets.TOKEN_TO_OPEN_PR }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't you need to add the permissions at the top of the action?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming like in CLI it'll pass the GH token: https://github.com/mongodb/mongodb-atlas-cli/blob/e6d5c2091c6b539c66da2e7e93abdc48abe0b743/.github/workflows/autoupdate-sdk.yaml#L26

commit-message: "build(deps): bump go.mongodb.org/atlas-sdk"
delete-branch: true
branch: atlas-sdk-update
Expand Down