fix: adjust root project_id attribute in mongdbatlas_project_api_key resource to optional
#1664
Conversation
| _, roleOk := d.GetOk("role_names") | ||
| if !roleOk { |
There was a problem hiding this comment.
legacy check, role_names no longer exists at root level.
| @@ -16,29 +16,32 @@ description: |- | |||
|
|
|||
| ## Example Usage | |||
|
|
|||
| ### Using org_id attribute to query | |||
There was a problem hiding this comment.
no changes in data source, just doc fixes I found
| @@ -17,29 +17,25 @@ description: |- | |||
| ## Example Usage | |||
|
|
|||
| ```terraform | |||
| resource "mongodbatlas_project_api_key" "test" { | |||
There was a problem hiding this comment.
no changes in data source, just doc fixes I found
| } | ||
|
|
||
| // creates api key using project id of first defined project assignment | ||
| firstAssignment := projectAssignmentList[0] |
There was a problem hiding this comment.
should this new behaviour be documented? is it a breaking change? What happens with project_id when it is actually defined? from this code it seems like it won't be used aynmore
There was a problem hiding this comment.
So this is more of an implementation detail: one project id is used for the creation of the api key, and then remaining projects assignments are assigned to the new api key. The previous implementation was essentially the same, only instead of taking the first element for the project assignment list it would grab the project which was defined in root project_id for the creation of the api key. From a users standpoint it is the same.
What happens with project_id when it is actually defined? from this code it seems like it won't be used anymore
This is correct, it is no longer used. From docs changes and deprecation warning users will be aware this attribute is no longer being used (https://github.com/mongodb/terraform-provider-mongodbatlas/pull/1665/files#diff-31571e18c14ed5632e87c050342b195d9cbc5092b465b08abfb8b1dcf87d37bdL49)
AgustinBettati
force-pushed
the
INTMDB-1296
branch
from
917bfe0 to
af2ad94
Compare
…resource to optional
AgustinBettati
force-pushed
the
INTMDB-1296
branch
from
af2ad94 to
8dd67d8
Compare
|
|
failing tests are related to "MAX_GROUPS_PER_ORG_EXCEEDED" issue in testing org, verified migration and acceptance tests are passing well. |
Description
Link to any related issue(s): INTMDB-1296
Making root
project_idattribute inmongdbatlas_project_api_keyoptional enables users to unassign the root project from the created API Key without having to delete the resource all together. More details in the referenced ticket.Type of change:
Required Checklist:
Further comments