feat: Updates migration tests to run separately and use last released version of provider for plan checks #1565
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| name: 'Migration Tests' | ||
|
|
||
| on: | ||
| workflow_dispatch: {} # workflow can be run manually | ||
| workflow_call: # workflow runs after code-health | ||
| inputs: | ||
| parent-event-name: | ||
| required: true | ||
| type: string | ||
| pull_request: # you can run a specic job in your PR using GitHub labels | ||
maastha marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| types: [ labeled ] | ||
|
|
||
| jobs: | ||
| change-detection: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| pull-requests: read | ||
| repository-projects: read | ||
| outputs: | ||
| project: ${{ steps.filter.outputs.project }} | ||
| config: ${{ steps.filter.outputs.config }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| if: ${{ github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule' || inputs.parent-event-name == 'release' }} | ||
| - uses: dorny/paths-filter@v2 | ||
| id: filter | ||
| with: | ||
| filters: | | ||
| project: | ||
| - 'mongodbatlas/fw_data_source_mongodbatlas_project_ip_access_list*.go' | ||
| - 'mongodbatlas/fw_resource_mongodbatlas_project_ip_access_list*.go' | ||
| config: | ||
| - 'mongodbatlas/fw_data_source_mongodbatlas_alert_configuration*.go' | ||
| - 'mongodbatlas/fw_data_source_mongodbatlas_database_user*.go' | ||
| - 'mongodbatlas/fw_data_source_mongodbatlas_atlas_user*.go' | ||
| - 'mongodbatlas/fw_resource_mongodbatlas_alert_configuration*.go' | ||
| - 'mongodbatlas/fw_resource_mongodbatlas_database_user*.go' | ||
|
|
||
| project: | ||
| needs: [ change-detection ] | ||
| if: ${{ needs.change-detection.outputs.project == 'true' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule' || github.event.label.name == 'run-testacc-migration' || github.event.label.name == 'run-testacc-project-migration' || inputs.parent-event-name == 'release' }} | ||
|
There was a problem hiding this comment. i know we have this in other gh actions but I wonder if we could make this easier or have some functions or something There was a problem hiding this comment. perhaps we could start fixing this file and then a follow-up to change the others? There was a problem hiding this comment. @lantoli I couldn't find a way to make this reusable or use a function, is there any example or reference you could share? There was a problem hiding this comment. I'm not sure about the best way, but for instance what about creating a variable in the workflow and use the variable? something like: on: ... env: job... and use: if: ${{ env.hasToTrigger }} There was a problem hiding this comment. or use it for the common part and then: There was a problem hiding this comment. since this doesn't hold a static value, rather holds a condition, i don't believe this is possible to do via a variable as well There was a problem hiding this comment. i suppose it's possible while you use variables that are know before starting execution There was a problem hiding this comment. Addressed, see comment #1565 (comment) |
||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| - name: Get Last Release | ||
| id: get_last_release | ||
| run: | | ||
| LAST_RELEASE=$(curl -sSfL -X GET https://api.github.com/repos/mongodb/terraform-provider-mongodbatlas/releases/latest | jq -r '.tag_name | ltrimstr("v")') | ||
| echo "Last release: $LAST_RELEASE" | ||
| echo "MONGODB_ATLAS_LAST_VERSION=$LAST_RELEASE" >> $GITHUB_ENV | ||
| shell: bash | ||
| - name: Set up Go | ||
| uses: actions/setup-go@v4 | ||
| with: | ||
| go-version-file: 'go.mod' | ||
| - name: Migration Tests | ||
| env: | ||
| MONGODB_ATLAS_PUBLIC_KEY: ${{ secrets.MONGODB_ATLAS_PUBLIC_KEY_CLOUD_DEV }} | ||
| MONGODB_ATLAS_PRIVATE_KEY: ${{ secrets.MONGODB_ATLAS_PRIVATE_KEY_CLOUD_DEV }} | ||
| MONGODB_ATLAS_ORG_ID: ${{ vars.MONGODB_ATLAS_ORG_ID_CLOUD_DEV }} | ||
| MONGODB_ATLAS_BASE_URL: ${{ vars.MONGODB_ATLAS_BASE_URL }} | ||
| MONGODB_ATLAS_PROJECT_OWNER_ID: ${{ vars.MONGODB_ATLAS_PROJECT_OWNER_ID }} | ||
| MONGODB_ATLAS_API_KEYS_IDS: ${{ vars.MONGODB_ATLAS_API_KEYS_IDS }} | ||
| MONGODB_ATLAS_TEAMS_IDS: ${{ vars.MONGODB_ATLAS_TEAMS_IDS }} | ||
| SKIP_TEST_EXTERNAL_CREDENTIALS: ${{ vars.SKIP_TEST_EXTERNAL_CREDENTIALS }} | ||
| ACCTEST_TIMEOUT: ${{ vars.ACCTEST_TIMEOUT }} | ||
| TF_LOG: ${{ vars.LOG_LEVEL }} | ||
| TF_ACC: 1 | ||
| PARALLEL_GO_TEST: 20 | ||
| CI: true | ||
| TEST_REGEX: "^TestAccMigrationProject" | ||
| run: make testacc | ||
|
|
||
| config: | ||
| needs: [ change-detection ] | ||
| if: ${{ needs.change-detection.outputs.config == 'true' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule' || github.event.label.name == 'run-testacc-migration' || github.event.label.name == 'run-testacc-config-migration' || inputs.parent-event-name == 'release' }} | ||
|
|
||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| - name: Get Last Release | ||
| id: get_last_release | ||
| run: | | ||
| LAST_RELEASE=$(curl -sSfL -X GET https://api.github.com/repos/mongodb/terraform-provider-mongodbatlas/releases/latest | jq -r '.tag_name | ltrimstr("v")') | ||
| echo "Last release: $LAST_RELEASE" | ||
| echo "MONGODB_ATLAS_LAST_VERSION=$LAST_RELEASE" >> $GITHUB_ENV | ||
| shell: bash | ||
| - name: Set up Go | ||
| uses: actions/setup-go@v4 | ||
| with: | ||
| go-version-file: 'go.mod' | ||
| - name: Migration Tests | ||
| env: | ||
| MONGODB_ATLAS_PUBLIC_KEY: ${{ secrets.MONGODB_ATLAS_PUBLIC_KEY_CLOUD_DEV_NETWORK }} | ||
| MONGODB_ATLAS_PRIVATE_KEY: ${{ secrets.MONGODB_ATLAS_PRIVATE_KEY_CLOUD_DEV_NETWORK }} | ||
| MONGODB_ATLAS_ORG_ID: ${{ vars.MONGODB_ATLAS_ORG_ID_CLOUD_DEV_NETWORK }} | ||
| MONGODB_ATLAS_BASE_URL: ${{ vars.MONGODB_ATLAS_BASE_URL }} | ||
| MONGODB_ATLAS_PROJECT_OWNER_ID: ${{ vars.MONGODB_ATLAS_PROJECT_OWNER_ID }} | ||
| SKIP_TEST_EXTERNAL_CREDENTIALS: ${{ vars.SKIP_TEST_EXTERNAL_CREDENTIALS }} | ||
| MONGODB_ATLAS_USERNAME_CLOUD_DEV: ${{ vars.MONGODB_ATLAS_USERNAME_CLOUD_DEV }} | ||
| AZURE_ATLAS_APP_ID: ${{vars.AZURE_ATLAS_APP_ID}} | ||
| AZURE_SERVICE_PRINCIPAL_ID: ${{vars.AZURE_SERVICE_PRINCIPAL_ID}} | ||
| AZURE_TENANT_ID: ${{vars.AZURE_TENANT_ID}} | ||
| ACCTEST_TIMEOUT: ${{ vars.ACCTEST_TIMEOUT }} | ||
| TF_LOG: ${{ vars.LOG_LEVEL }} | ||
| TF_ACC: 1 | ||
| PARALLEL_GO_TEST: 20 | ||
| CI: true | ||
| TEST_REGEX: "^TestAccMigrationConfig" | ||
| run: make testacc | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finally, thanks! :-)