Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixes region and aws account to be used for trigger acc test #1558

Merged
merged 8 commits into from
Oct 30, 2023

Conversation

marcosuma
Copy link
Collaborator

Related to: https://jira.mongodb.org/browse/INTMDB-1010

As part of enabling trigger creation acceptance tests we need to correctly set up the existing tests. With this change we are using the correct aws_region and aws_account_id when using AWS_EVENTBRIDGE during tests and calling our dev endpoint.

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

@marcosuma marcosuma marked this pull request as ready for review October 24, 2023 15:43
@marcosuma marcosuma requested a review from a team as a code owner October 24, 2023 15:43
@marcosuma
Copy link
Collaborator Author

Next actions:

  1. How to create a function, app and service IDs?
    • They are basically the env variables MONGODB_REALM_APP_ID, MONGODB_REALM_FUNCTION_ID and MONGODB_REALM_SERVICE_ID
  2. Enable tests to be executed as part of CI/CD

@github-actions
Copy link
Contributor

Code Coverage

Package Line Rate Health
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 2%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/framework/validator 68%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/util 17%
Summary 3% (272 / 10318)

@marcosuma marcosuma merged commit 7ba7282 into master Oct 30, 2023
21 checks passed
@marcosuma marcosuma deleted the INTMDB-1010-fix-eventbridge-tests branch October 30, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants