Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Updates to Go 1.21.3 #1550

Merged
merged 9 commits into from
Oct 24, 2023
Merged

feat: Updates to Go 1.21.3 #1550

merged 9 commits into from
Oct 24, 2023

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Oct 24, 2023

Description

Jira ticket: INTMDB-1209

Updates to Go 1.21.3

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

@lantoli lantoli marked this pull request as ready for review October 24, 2023 09:06
@lantoli lantoli requested a review from a team as a code owner October 24, 2023 09:06
lantoli
lantoli commented Oct 24, 2023
View reviewed changes
.golangci.yml Outdated Show resolved Hide resolved
gssbzn
gssbzn reviewed Oct 24, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
gssbzn
gssbzn reviewed Oct 24, 2023
View reviewed changes
CONTRIBUTING.md Outdated
```
~> **Notice:** For more information about the PrivateLink (for AWS only), see: https://docs.atlas.mongodb.com/reference/api/encryption-at-rest/https://docs.atlas.mongodb.com/reference/api/private-endpoint/

~> **Notice:** For more information about the PrivateLink (for AWS only), see: <https://docs.atlas.mongodb.com/reference/api/encryption-at-rest/https://docs.atlas.mongodb.com/reference/api/private-endpoint/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case you want to improve how this renders https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts

gssbzn
gssbzn reviewed Oct 24, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
gssbzn
gssbzn reviewed Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general LGTM except for specifying a patch version in the go version

gssbzn
gssbzn approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lantoli
remove linters not being used because abandoned.
819fd8f 
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
@github-actions
Copy link
Contributor

Code Coverage

Package Line Rate Health
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/framework/validator 68% ➖
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/util 12% ❌
Summary 3% (271 / 10296) ❌

@lantoli lantoli merged commit f0395d8 into master Oct 24, 2023
19 checks passed
@lantoli lantoli deleted the INTMDB-1209_go1.21.3 branch October 24, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@wtrocki wtrocki Awaiting requested review from wtrocki

@AgustinBettati AgustinBettati Awaiting requested review from AgustinBettati

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lantoli @gssbzn