Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixes setting of authentication realm url. #1537

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

marcosuma
Copy link
Collaborator

Description

When authenticating to App Service (Realm) there is a bug that impedes using a base_url different than realm.mongodb.com. As such, using realm-dev is not possible. With this fix, we are able to successfully authenticate. This is not an external bug.

Link to any related issue(s): https://jira.mongodb.org/browse/INTMDB-1010

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

@marcosuma marcosuma changed the title fixes setting of authentication realm url. feat: fixes setting of authentication realm url. Oct 19, 2023
@marcosuma marcosuma marked this pull request as ready for review October 19, 2023 11:26
@marcosuma marcosuma requested a review from a team as a code owner October 19, 2023 11:26
go.mod Outdated Show resolved Hide resolved
go.sum Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Code Coverage

Package Line Rate Health
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 2%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/framework/validator 68%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/util 12%
Summary 3% (271 / 10310)

@marcosuma marcosuma merged commit 5f0cb4a into master Oct 20, 2023
19 checks passed
@marcosuma marcosuma deleted the INTMDB-1010-add-support-for-realm-dev branch October 20, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants