doc: Generate CHANGELOG #1531
Merged
doc: Generate CHANGELOG #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaangiolillo
changed the title
lantoli
reviewed
Oct 17, 2023
lantoli
reviewed
Oct 17, 2023
lantoli
reviewed
Oct 17, 2023
lantoli
approved these changes
Oct 17, 2023
lantoli
reviewed
Oct 17, 2023
lantoli
reviewed
Oct 17, 2023
davidhou17
reviewed
Oct 17, 2023
| - Adds coverage report to PRs [\#1496](https://github.com/mongodb/terraform-provider-mongodbatlas/pull/1496) ([andreaangiolillo](https://github.com/andreaangiolillo)) | ||
| - Adds sagemaker quickstart to repo [\#1494](https://github.com/mongodb/terraform-provider-mongodbatlas/pull/1494) ([govardhanpagidi](https://github.com/govardhanpagidi)) | ||
| - Closes code block in "Resource: Cloud Provider Access Configuration Paths" documentation page [\#1487](https://github.com/mongodb/terraform-provider-mongodbatlas/pull/1487) ([mattt416](https://github.com/mattt416)) | ||
| - Bump github.com/gruntwork-io/terratest from 0.43.13 to 0.44.0 [\#1482](https://github.com/mongodb/terraform-provider-mongodbatlas/pull/1482) ([dependabot[bot]](https://github.com/apps/dependabot)) |
There was a problem hiding this comment.
[nit] This applies to the remaining occurrences of "bump" as well
Suggested change
| - Bump github.com/gruntwork-io/terratest from 0.43.13 to 0.44.0 [\#1482](https://github.com/mongodb/terraform-provider-mongodbatlas/pull/1482) ([dependabot[bot]](https://github.com/apps/dependabot)) | |
| - Bumps github.com/gruntwork-io/terratest from 0.43.13 to 0.44.0 [\#1482](https://github.com/mongodb/terraform-provider-mongodbatlas/pull/1482) ([dependabot[bot]](https://github.com/apps/dependabot)) |
Zuhairahmed
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
LGTM, few minor nits. Let me know if you need to chat on anything. Great work @AgustinBettati / @andreaangiolillo !
|
|
||
| - Removes the data source mongodbatlas_privatelink_endpoint_service_adl [\#1503](https://github.com/mongodb/terraform-provider-mongodbatlas/pull/1503) ([marcosuma](https://github.com/marcosuma)) | ||
| - Removes the data source mongodbatlas_privatelink_endpoints_service_adl [\#1503](https://github.com/mongodb/terraform-provider-mongodbatlas/pull/1503) ([marcosuma](https://github.com/marcosuma)) | ||
| - Removes mongodbatlas_privatelink_endpoint_service_adl [\#1503](https://github.com/mongodb/terraform-provider-mongodbatlas/pull/1503) ([marcosuma](https://github.com/marcosuma)) |
There was a problem hiding this comment.
Suggested change
| - Removes mongodbatlas_privatelink_endpoint_service_adl [\#1503](https://github.com/mongodb/terraform-provider-mongodbatlas/pull/1503) ([marcosuma](https://github.com/marcosuma)) |
Co-authored-by: davidhou17 <[email protected]>
Co-authored-by: davidhou17 <[email protected]>
Co-authored-by: davidhou17 <[email protected]>
Co-authored-by: davidhou17 <[email protected]>
Co-authored-by: davidhou17 <[email protected]>
Co-authored-by: davidhou17 <[email protected]>
Co-authored-by: davidhou17 <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
|
1 similar comment
|
marcosuma
approved these changes
Oct 18, 2023
AgustinBettati
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the fix/feature/change, including any relevant motivation and context.
Link to any related issue(s):
Type of change:
Required Checklist:
Further comments