Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Close code block in "Resource: Cloud Provider Access Configuration Paths" documentation page #1487

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

mattt416
Copy link
Contributor

Description

The Resource: Cloud Provider Access Configuration Paths documentation page currently does not render correctly due to missing closing code block.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

Page currently does not render correctly due to closing code block.
@mattt416 mattt416 requested a review from a team as a code owner September 20, 2023 19:09
@mattt416 mattt416 changed the title Close code block in "Resource: Cloud Provider Access Configuration Paths" documentation page doc: Close code block in "Resource: Cloud Provider Access Configuration Paths" documentation page Sep 20, 2023
Copy link
Collaborator

@jwilliams-mongo jwilliams-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zuhairahmed LGTM. One other formatting issue I see is on line 64 there seems to be an extra "" after provider_name` (can't comment there on the PR)

at a glance all the other formatting looks OK

@mattt416
Copy link
Contributor Author

@jwilliams-mongo Just added another commit for that. Thanks for catching!

Copy link
Collaborator

@jwilliams-mongo jwilliams-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattt416 LGTM

@github-actions
Copy link
Contributor

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

@github-actions github-actions bot added the stale label Oct 10, 2023
@mattt416
Copy link
Contributor Author

@jwilliams-mongo @maastha is this PR waiting on something from me?

@jwilliams-mongo
Copy link
Collaborator

jwilliams-mongo commented Oct 10, 2023

@mattt416 LGTM from here. I think it just needs to be merged. I don't have write access, so it will have to be @maastha or someone else from the engineering team.

@github-actions github-actions bot removed the stale label Oct 11, 2023
@andreaangiolillo andreaangiolillo merged commit f1d4ad8 into mongodb:master Oct 11, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants