Fix snapshot import with hyphened cluster_name #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
marinsalinas
force-pushed
the
fix-snapshot-import
branch
from
09daa95 to
b95828a
Compare
|
Hello @sushilvarma2, could you please validate if the error is still happening? |
themantissa
approved these changes
Feb 11, 2020
| @@ -166,3 +170,25 @@ func testAccMongoDBAtlasCloudProviderSnapshotConfig(projectID, clusterName, desc | |||
| } | |||
| `, projectID, clusterName, description, retentionInDays) | |||
| } | |||
|
|
|||
| func TestResourceMongoDBAtlasCloudProviderSnapshot_snapshotID(t *testing.T) { | |||
There was a problem hiding this comment.
Just a note: If this works well then we'll probably want to add this to all import statements since if the project name has hyphens it would fail with any import that isn't ignoring in value hyphens.
There was a problem hiding this comment.
yes, it would be great to add it to the remaining resources. But I think by the next release because I wouldn't like to break something. 😅
PacoDw
reviewed
Feb 12, 2020
PacoDw
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #109