Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-911: [Terraform] Remove unused secret from code-health workflow #1291

Merged
merged 1 commit into from
Jul 4, 2023
Merged

INTMDB-911: [Terraform] Remove unused secret from code-health workflow #1291

merged 1 commit into from
Jul 4, 2023

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Jul 4, 2023 •
edited
Loading

Description

Ticket: INTMDB-911

This PR removes the secret MONGODB_ATLAS_TEAMS_IDS from the unit-test as is not used.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo requested a review from a team as a code owner July 4, 2023 11:02
@andreaangiolillo andreaangiolillo marked this pull request as draft July 4, 2023 11:03
@andreaangiolillo andreaangiolillo marked this pull request as ready for review July 4, 2023 11:03
gssbzn
gssbzn approved these changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo merged commit b68ca05 into master Jul 4, 2023
@andreaangiolillo andreaangiolillo deleted the INTMDB-911 branch July 4, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaangiolillo @gssbzn