Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'pause' during cluster and advanced_cluster update #1248

Merged
merged 6 commits into from
Jun 21, 2023

Conversation

maastha
Copy link
Collaborator

@maastha maastha commented Jun 16, 2023

Description

Jira Ticket: https://jira.mongodb.org/browse/INTMDB-875

This Pr resolves bug from https://jira.mongodb.org/browse/HELP-46575 where we do not properly update 'pause' and 'unpause' attribute in mongodbatlas_cluster anf mongodbatlas_advanced_cluster resources.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@maastha maastha marked this pull request as ready for review June 19, 2023 12:56
@maastha maastha requested a review from a team as a code owner June 19, 2023 12:56
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if all tests are 🟢 . Great work here 💯

Copy link
Collaborator

@Zuhairahmed Zuhairahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@martinstibbe martinstibbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maastha maastha merged commit 9f7d9c7 into master Jun 21, 2023
@maastha maastha deleted the INTMDB-875-cluster-pause branch June 21, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants