Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTMDB-720: [Terraform] Investigate ChangeLog Generator #1165

Merged
merged 2 commits into from
May 15, 2023

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented May 12, 2023

Description

As part of INTMDB-720, we discovered how we can automatically generate CHANGELOG.md with the format that we want. This requires us to add labels to the PR that we want to show in specific sections of the changelog.

Proposed Changes:
This PR updates the PR template to explain when we should add the label and which label to use depending on the PR change and create a RELEASING.md file to include the correct command to generate the CHANGELOG.md.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo marked this pull request as ready for review May 15, 2023 09:05
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner May 15, 2023 09:05
Copy link
Collaborator

@Zuhairahmed Zuhairahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @martinstibbe @maastha @evertsd can you make sure to add these labels to your future PRs as well ChangeLog Generator can pick up for us. Thank you!

@andreaangiolillo andreaangiolillo merged commit 882524f into master May 15, 2023
@andreaangiolillo andreaangiolillo deleted the INTMDB-720 branch July 17, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants