Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update project_api_key.html.markdown #1044

Merged
merged 2 commits into from
Feb 20, 2023
Merged

Update project_api_key.html.markdown #1044

merged 2 commits into from
Feb 20, 2023

Conversation

ThomasVictoria
Copy link
Contributor

Remove spare bracket

Description

Just remove a useless bracket from the mongodbatlas_project_api_key resource

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@ThomasVictoria ThomasVictoria requested a review from a team as a code owner February 6, 2023 11:27
@Zuhairahmed Zuhairahmed self-requested a review February 6, 2023 19:14
@Zuhairahmed
Copy link
Collaborator

Zuhairahmed commented Feb 6, 2023 •
edited
Loading

@ThomasVictoria this is a great catch. Few comments:

  1. Please make sure to sign our Contributors Agreement: https://www.mongodb.com/legal/contributor-agreement
  2. PRs are submitted against the current release branch, not master. The naming of the current release branch is release-staging-v1.8.1
  3. Please review all other contributing guidelines: https://github.com/mongodb/terraform-provider-mongodbatlas/blob/master/CONTRIBUTING.md

martinstibbe
martinstibbe suggested changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@martinstibbe martinstibbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we direct this at release-staging-v1.8.1 branch vs master

@ThomasVictoria ThomasVictoria changed the base branch from master to release-staging-v1.8.1 February 7, 2023 08:57
@ThomasVictoria
Copy link
Contributor Author

@ThomasVictoria this is a great catch. Few comments:

  1. Please make sure to sign our Contributors Agreement: https://www.mongodb.com/legal/contributor-agreement
  2. PRs are submitted against the current release branch, not master. The naming of the current release branch is release-staging-v1.8.1
  3. Please review all other contributing guidelines: https://github.com/mongodb/terraform-provider-mongodbatlas/blob/master/CONTRIBUTING.md

Just signed the contributor agreement

Zuhairahmed
Zuhairahmed approved these changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@Zuhairahmed Zuhairahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again @ThomasVictoria!

@Zuhairahmed Zuhairahmed merged commit 73acc67 into mongodb:release-staging-v1.8.1 Feb 20, 2023
martinstibbe added a commit that referenced this pull request Mar 6, 2023
@martinstibbe @Zuhairahmed
@dependabot @andreaangiolillo @evertsd @ThomasVictoria @robbertkauffman
v1.8.1 Pre Release (#1088)
98b2660 
* INTMDB-390: Upgrade to go1.19 (#1031)

* Update go version references to 1.19 go mod tidy

* Update CHANGELOG.md

* Chore(deps): Bump golangci/golangci-lint-action from 3.3.1 to 3.4.0 (#1026)

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.3.1 to 3.4.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v3.3.1...v3.4.0)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update golangci-lint.yml

* Update version and timeout

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Set SMS email from schema to carry value of boolean forward (#1029)

* Add metric_threshold_config threshold_config in read provider (#1030)

* INTMDB-440: Update ldap_configuration broken (#1033)

* Update CHANGELOG.md

* Chore(deps): Bump golangci/golangci-lint-action from 3.3.1 to 3.4.0 (#1026)

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.3.1 to 3.4.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v3.3.1...v3.4.0)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add authentication_enabled parameter to LDAPConfigurationUpdate

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* INTMDB-556: Regression in 1.8.0: mongodbatlas_third_party_integration marks "type" attribute as deprecated (#1034)

* Update CHANGELOG.md

* Chore(deps): Bump golangci/golangci-lint-action from 3.3.1 to 3.4.0 (#1026)

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.3.1 to 3.4.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v3.3.1...v3.4.0)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add warning for deprecated integration types

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* INTMDB-32: Add example for NVME upgrade (#1037)

* Update CHANGELOG.md

* Chore(deps): Bump golangci/golangci-lint-action from 3.3.1 to 3.4.0 (#1026)

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.3.1 to 3.4.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v3.3.1...v3.4.0)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add example for NVME upgrade

* Update examples/atlas-cluster/nvme-upgrade/README.md

Co-authored-by: Zuhair Ahmed <[email protected]>

* Update examples/atlas-cluster/nvme-upgrade/README.md

Co-authored-by: Zuhair Ahmed <[email protected]>

* Update examples/atlas-cluster/nvme-upgrade/README.md

Co-authored-by: Zuhair Ahmed <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* INTMDB-424: Add AWS and Azure serverless private link examples (#1043)

* Add AWS and Azure serverless private link examples

* Remove unused variable

* INTMDB-560: cloud_provider_access_authorization and encryption_at_rest improvements (#1045)

* Add additional logging and retries based on error code

* Lint add catch error handler at end if fails after retry

* Fix missing groupID

* Update resource_mongodbatlas_encryption_at_rest.go

* Correct import statement error handler to match docs (#1046)

* INTMDB-570: ERROR: Pager Duty API key must consist of 32 hexadecimal digits (#1054)

* Update codeowner to use APIx-Integrations (#1050)

* Add support for retaining service key values

* Fix matcher test

* Update third party testing

* Lint

---------

Co-authored-by: Andrea Angiolillo <[email protected]>

* INTMDB 508 - Configurable Timeouts for Resources dependent on Advanced Cluster IDLE (#1047)

* PrivateEndpointRegionalMode now takes timeout values for CUD and respects them on waiting for advanced clusters to IDLE

* Added timeouts documentation for private endpoint regional mode

* provider_backup_enabled deprecated to cloud_backup (#1036)

* Update CHANGELOG.md

* Chore(deps): Bump golangci/golangci-lint-action from 3.3.1 to 3.4.0 (#1026)

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.3.1 to 3.4.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v3.3.1...v3.4.0)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* provider_backup_enabled deprecated to cloud_backup

* replace with cloud_backup parameter

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* INTMDB-517: Event Trigger Error Handler Update (#1061)

* Event Trigger Docs Update

* Update event_trigger.html.markdown

* Update event_triggers.html.markdown

* Update codeowner to use APIx-Integrations (#1050)

* Chore(deps): Bump github.com/gruntwork-io/terratest (#1051)

Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.41.9 to 0.41.10.
- [Release notes](https://github.com/gruntwork-io/terratest/releases)
- [Commits](gruntwork-io/terratest@v0.41.9...v0.41.10)

---
updated-dependencies:
- dependency-name: github.com/gruntwork-io/terratest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Chore(deps): Bump github.com/hashicorp/hcl/v2 from 2.15.0 to 2.16.0 (#1055)

Bumps [github.com/hashicorp/hcl/v2](https://github.com/hashicorp/hcl) from 2.15.0 to 2.16.0.
- [Release notes](https://github.com/hashicorp/hcl/releases)
- [Changelog](https://github.com/hashicorp/hcl/blob/main/CHANGELOG.md)
- [Commits](hashicorp/hcl@v2.15.0...v2.16.0)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/hcl/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update resource_mongodbatlas_event_trigger.go

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: Andrea Angiolillo <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* INTMDB-571: POST Create Access List Entries for One Organization API Key endpoint supports list, but Terraform does not (#1065)

* Add example for multiple IP and  CIDR blocks

* Tidy up variables

* Update examples/atlas-ip-access-list/main.tf

Co-authored-by: Zuhair Ahmed <[email protected]>

* Update examples/atlas-ip-access-list/main.tf

Co-authored-by: Zuhair Ahmed <[email protected]>

---------

Co-authored-by: Zuhair Ahmed <[email protected]>

* INTMDB-572: HELP-42215 - PATCH Update Advanced Configuration Options for One Cluster / Advance Cluster (#1066)

* improve detection of empty struct

* Make cluster update when actual changes are present

* Update alert_configuration.html.markdown (#1068)

* Update access_list_api_key.html.markdown (#1058)

* Update alert_configuration.html.markdown

* Update website/docs/r/alert_configuration.html.markdown

* Doc Clean Up Cloud Provider Access (#1035)

* Update CHANGELOG.md

* Chore(deps): Bump golangci/golangci-lint-action from 3.3.1 to 3.4.0 (#1026)

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.3.1 to 3.4.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v3.3.1...v3.4.0)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Doc Clean Up Cloud Provider Access

* Update cloud_provider_access.markdown

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update project_api_key.html.markdown (#1044)

* Update project_api_key.html.markdown

Remove spare bracket

* Update project_api_key.html.markdown

Indent

* typo in readme (#1073)

* Update access_list_api_key.html.markdown (#1058)

* typo in readme

* INTMDB-600: Add support for conditional timeout for search index build (#1077)

* Update access_list_api_key.html.markdown (#1058)

* Add support for conditional timeout for search index build

* fix lint

---------

Co-authored-by: Zuhair Ahmed <[email protected]>

* Trigger index rebuild on cluster or project change (#1078)

* Improved encryption at rest example (#1060)

* create key in KMS and restrict IAM policy to key

* added readme

* removed other encryption examples as they're redundant

* fixed formatting

* INTMDB-410: PrivateLink Endpoint Examples + Documentation Cleanup (#1082)

* Clarified examples and documentation around using privatelink endpoints and getting connection strings in a single terraform apply on clusters/serverless instances

* fixed tflint failure

* Updated serverless-instance to provide more clarity on outputting connection strings

* Update .github_changelog_generator

* Update CHANGELOG.md

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrea Angiolillo <[email protected]>
Co-authored-by: Dosty Everts <[email protected]>
Co-authored-by: Thomas Victoria <[email protected]>
Co-authored-by: robbertkauffman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zuhairahmed Zuhairahmed Zuhairahmed approved these changes

@martinstibbe martinstibbe Awaiting requested review from martinstibbe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThomasVictoria @Zuhairahmed @martinstibbe