-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.8.0 staging #1018
v1.8.0 staging #1018
Conversation
* Add support for mongodbatlas_roles_org_id * Add Documentation for roles_org_id * Update go library * Add mongodbatlas_roles_org_id to datasource and resource to provide org_id * doc clean up / link to new API docs * formatting fix + update links to new API docs * formatting + update link to new API docs * formatting Co-authored-by: Zuhair Ahmed <[email protected]>
* Chore(deps): Bump github.com/gruntwork-io/terratest (#978) Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.41.6 to 0.41.7. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.41.6...v0.41.7) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore(deps): Bump actions/stale from 6 to 7 (#977) Bumps [actions/stale](https://github.com/actions/stale) from 6 to 7. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v6...v7) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * v1.7.0 Pre-Release (#980) * Delete mongodbatlas.erb (#962) * INTMDB-523: Rename exportJobID to exportID to match go client (#976) * Updated version of atlas api client used, renamed bucketID to exportJobID * Reverted changes to bucketID and updated exportJobID to exportID * INTMDB-521: AWS Secrets Manager to Auth into Terraform Atlas Provider (#975) * Add support for assume_role * Add documentation for assume_role feature * Add AWS parameters Env vars * Update index.html.markdown * Doc clean up * typo * Add regional behavior to endpoint sts client * Add sts_endpoint parameter * Update website/docs/index.html.markdown * formatting * formatting2 * Removed commented code Co-authored-by: Zuhair Ahmed <[email protected]> * Update .github_changelog_generator Co-authored-by: Dosty Everts <[email protected]> Co-authored-by: Zuhair Ahmed <[email protected]> * Revert "v1.7.0 Pre-Release (#980)" (#982) This reverts commit 7a57d21. * Add deprecation notices * Additional deprecation details * Add more detail * Update resource_mongodbatlas_private_ip_mode.go * Update resource_mongodbatlas_private_ip_mode.go * Update resource_mongodbatlas_private_ip_mode.go Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dosty Everts <[email protected]> Co-authored-by: Zuhair Ahmed <[email protected]>
* Chore(deps): Bump github.com/gruntwork-io/terratest (#978) Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.41.6 to 0.41.7. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.41.6...v0.41.7) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore(deps): Bump actions/stale from 6 to 7 (#977) Bumps [actions/stale](https://github.com/actions/stale) from 6 to 7. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v6...v7) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * v1.7.0 Pre-Release (#980) * Delete mongodbatlas.erb (#962) * INTMDB-523: Rename exportJobID to exportID to match go client (#976) * Updated version of atlas api client used, renamed bucketID to exportJobID * Reverted changes to bucketID and updated exportJobID to exportID * INTMDB-521: AWS Secrets Manager to Auth into Terraform Atlas Provider (#975) * Add support for assume_role * Add documentation for assume_role feature * Add AWS parameters Env vars * Update index.html.markdown * Doc clean up * typo * Add regional behavior to endpoint sts client * Add sts_endpoint parameter * Update website/docs/index.html.markdown * formatting * formatting2 * Removed commented code Co-authored-by: Zuhair Ahmed <[email protected]> * Update .github_changelog_generator Co-authored-by: Dosty Everts <[email protected]> Co-authored-by: Zuhair Ahmed <[email protected]> * Revert "v1.7.0 Pre-Release (#980)" (#982) This reverts commit 7a57d21. * V1.7.0 staging (#984) * Delete mongodbatlas.erb (#962) * INTMDB-523: Rename exportJobID to exportID to match go client (#976) * Updated version of atlas api client used, renamed bucketID to exportJobID * Reverted changes to bucketID and updated exportJobID to exportID * INTMDB-521: AWS Secrets Manager to Auth into Terraform Atlas Provider (#975) * Add support for assume_role * Add documentation for assume_role feature * Add AWS parameters Env vars * Update index.html.markdown * Doc clean up * typo * Add regional behavior to endpoint sts client * Add sts_endpoint parameter * Update website/docs/index.html.markdown * formatting * formatting2 * Removed commented code Co-authored-by: Zuhair Ahmed <[email protected]> * Update .github_changelog_generator * Update CHANGELOG.md * Changelog Cleanup * 1.7.0 Upgrade and Information Guide Co-authored-by: Dosty Everts <[email protected]> Co-authored-by: Zuhair Ahmed <[email protected]> * AWS_SM_Doc_Adds (#986) * Adding Instructions to dev versions of provider (#987) * Add deprecation relating to NEW_RELIC, FLOWDOCK Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dosty Everts <[email protected]> Co-authored-by: Zuhair Ahmed <[email protected]>
* Chore(deps): Bump github.com/gruntwork-io/terratest (#978) Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.41.6 to 0.41.7. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.41.6...v0.41.7) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore(deps): Bump actions/stale from 6 to 7 (#977) Bumps [actions/stale](https://github.com/actions/stale) from 6 to 7. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v6...v7) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * v1.7.0 Pre-Release (#980) * Delete mongodbatlas.erb (#962) * INTMDB-523: Rename exportJobID to exportID to match go client (#976) * Updated version of atlas api client used, renamed bucketID to exportJobID * Reverted changes to bucketID and updated exportJobID to exportID * INTMDB-521: AWS Secrets Manager to Auth into Terraform Atlas Provider (#975) * Add support for assume_role * Add documentation for assume_role feature * Add AWS parameters Env vars * Update index.html.markdown * Doc clean up * typo * Add regional behavior to endpoint sts client * Add sts_endpoint parameter * Update website/docs/index.html.markdown * formatting * formatting2 * Removed commented code Co-authored-by: Zuhair Ahmed <[email protected]> * Update .github_changelog_generator Co-authored-by: Dosty Everts <[email protected]> Co-authored-by: Zuhair Ahmed <[email protected]> * Revert "v1.7.0 Pre-Release (#980)" (#982) This reverts commit 7a57d21. * V1.7.0 staging (#984) * Delete mongodbatlas.erb (#962) * INTMDB-523: Rename exportJobID to exportID to match go client (#976) * Updated version of atlas api client used, renamed bucketID to exportJobID * Reverted changes to bucketID and updated exportJobID to exportID * INTMDB-521: AWS Secrets Manager to Auth into Terraform Atlas Provider (#975) * Add support for assume_role * Add documentation for assume_role feature * Add AWS parameters Env vars * Update index.html.markdown * Doc clean up * typo * Add regional behavior to endpoint sts client * Add sts_endpoint parameter * Update website/docs/index.html.markdown * formatting * formatting2 * Removed commented code Co-authored-by: Zuhair Ahmed <[email protected]> * Update .github_changelog_generator * Update CHANGELOG.md * Changelog Cleanup * 1.7.0 Upgrade and Information Guide Co-authored-by: Dosty Everts <[email protected]> Co-authored-by: Zuhair Ahmed <[email protected]> * AWS_SM_Doc_Adds (#986) * Adding Instructions to dev versions of provider (#987) * doc formatting edits (#990) * doc formatting (#991) * Add import example for Encryption at Rest Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dosty Everts <[email protected]> Co-authored-by: Zuhair Ahmed <[email protected]>
…se Users are Created (#985) * Chore(deps): Bump github.com/gruntwork-io/terratest (#978) Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.41.6 to 0.41.7. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.41.6...v0.41.7) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore(deps): Bump actions/stale from 6 to 7 (#977) Bumps [actions/stale](https://github.com/actions/stale) from 6 to 7. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v6...v7) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Initial attempt at moving certificate out of ID * Find latest ID Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* example fix * log to file add * formating * formatting updates * Example fix Resource: mongodbatlas_federated_settings_org_config
* Initial version * Add support for api key test cases * Update documents * Update website/docs/r/api_key.html.markdown Co-authored-by: Zuhair Ahmed <[email protected]> * Update website/docs/d/api_keys.html.markdown Co-authored-by: Zuhair Ahmed <[email protected]> * Update website/docs/d/api_key.html.markdown Co-authored-by: Zuhair Ahmed <[email protected]> * initial addition of tests * Update project api keys tests * Commented code removal * Update Docs rename resource * Add warning and update reference link to new docs * Update reference links to new docs * Update reference link to new docs * formatting * link fix Co-authored-by: Zuhair Ahmed <[email protected]>
…as_cloud_backup_schedule resource (#1014) * skip update_snapshots on read as API does not return current value * Doc update * Update website/docs/r/cloud_backup_schedule.html.markdown Co-authored-by: Zuhair Ahmed <[email protected]>
#1010) * Add support for migrating bi_connector to bi_connector_config * Add deprecated parameter pathway for upgrade and test
…dating on every apply (#1011) * Add additional overrides for obfuscated API values set to parameters * Add username to sensitive values * Add WebHook secret and URL to manage drift
* example fix * log to file add * formating * formatting updates * Add mutex to prevent concurrent API calls datasource simplify count as it picks up other tests Co-authored-by: Zuhair Ahmed <[email protected]>
* Update for breaking change in mongodb go library * go mod tidy * Update error logging and constant
* Addressing failures on cloud backup schedule * Updated condition for updating export request
* Fixed casing on search_index attribute casing in update. Updated formatting on test json * More formatting of string based tf configs
* Chore(deps): Bump github.com/gruntwork-io/terratest (#978) Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.41.6 to 0.41.7. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.41.6...v0.41.7) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore(deps): Bump actions/stale from 6 to 7 (#977) Bumps [actions/stale](https://github.com/actions/stale) from 6 to 7. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v6...v7) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * v1.7.0 Pre-Release (#980) * Delete mongodbatlas.erb (#962) * INTMDB-523: Rename exportJobID to exportID to match go client (#976) * Updated version of atlas api client used, renamed bucketID to exportJobID * Reverted changes to bucketID and updated exportJobID to exportID * INTMDB-521: AWS Secrets Manager to Auth into Terraform Atlas Provider (#975) * Add support for assume_role * Add documentation for assume_role feature * Add AWS parameters Env vars * Update index.html.markdown * Doc clean up * typo * Add regional behavior to endpoint sts client * Add sts_endpoint parameter * Update website/docs/index.html.markdown * formatting * formatting2 * Removed commented code Co-authored-by: Zuhair Ahmed <[email protected]> * Update .github_changelog_generator Co-authored-by: Dosty Everts <[email protected]> Co-authored-by: Zuhair Ahmed <[email protected]> * Revert "v1.7.0 Pre-Release (#980)" (#982) This reverts commit 7a57d21. * V1.7.0 staging (#984) * Delete mongodbatlas.erb (#962) * INTMDB-523: Rename exportJobID to exportID to match go client (#976) * Updated version of atlas api client used, renamed bucketID to exportJobID * Reverted changes to bucketID and updated exportJobID to exportID * INTMDB-521: AWS Secrets Manager to Auth into Terraform Atlas Provider (#975) * Add support for assume_role * Add documentation for assume_role feature * Add AWS parameters Env vars * Update index.html.markdown * Doc clean up * typo * Add regional behavior to endpoint sts client * Add sts_endpoint parameter * Update website/docs/index.html.markdown * formatting * formatting2 * Removed commented code Co-authored-by: Zuhair Ahmed <[email protected]> * Update .github_changelog_generator * Update CHANGELOG.md * Changelog Cleanup * 1.7.0 Upgrade and Information Guide Co-authored-by: Dosty Everts <[email protected]> Co-authored-by: Zuhair Ahmed <[email protected]> * AWS_SM_Doc_Adds (#986) * Adding Instructions to dev versions of provider (#987) * doc formatting edits (#990) * doc formatting (#991) * Initial analytics scaling * Add Documentation updates for analytics_auto_scaling * Update advanced_cluster.html.markdown * Add testing for analytics scaling * example fix * log to file add * formating * formatting updates * Add mutex to custom db role API call to avoid overlapping API calls * Add back test mutex fixed API concurrency issue * Rollback 448 changes pushed to incorrect branch Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dosty Everts <[email protected]> Co-authored-by: Zuhair Ahmed <[email protected]>
… a project (#993) * Added alert_configurations data_source * Added documentation on how to use data_source_alert_configuration outputs, as well as the new data source for all alert configurations * Removed duplicate function declaration * Resolving lint errors around looping * Added example for importing atlas-alert-configurations en masse * Got tests passing, added documentation for alert_configuration data_source * Fixed alert_configurations test * Updated readme to include instructions for creating the data source * Fixed spacing and added a link to the full example on the data source docs
* Add CopySettings support * Add feature for snapshot replication * Update go.mod * Update go.sum * Update go.mod * Add example for resource with snapshot distribution * Add recommended if else approach bring go-client to latest master to pickup empty struct * Add note about deleteCopiedBackups
* Started work on state migration * Got StateUpgrader for v0 to v1 working & added test * Updated flattenAdvancedReplicationSpecs algorithm to ensure order is maintained between api & tf state * Fixed lint issues * Migrated replication_spec migration code to be encompassed by bi connector migration
#1007) * Updates documenation for mongodbatlas_cloud_backup_schedule by adding more information about possible values for frequency_type, frequency_interval, retention_unit and retention_value. * Updates documenation for mongodbatlas_cloud_backup_schedule by adding more information about possible values for frequency_type, frequency_interval, retention_unit and retention_value. * Adds comments to the examples for more context * Removes unnecessary colons. * Fixed spelling mistake
This change adjusts the BI Connector documentation snippet by: - Replacing the reference to `bi_connector` with `bi_connector_config` - Wrapping the `secondary` string in double quotes - Fixing inconsistent spacing
…pdate (#1016) * Chore(deps): Bump github.com/gruntwork-io/terratest (#1013) Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.41.7 to 0.41.9. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.41.7...v0.41.9) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add support for oplog_min_retention_hours * Update website/docs/r/advanced_cluster.html.markdown * Update website/docs/r/cluster.html.markdown * Update mongodbatlas/resource_mongodbatlas_cluster.go Co-authored-by: Wojciech Trocki <[email protected]> * Restructure suggested code * restructure * Allow zero for oplog_min_retention_hours Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zuhair Ahmed <[email protected]> Co-authored-by: Wojciech Trocki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Updated CHANGELOG directly, feel free to adjust as well as needed
@@ -55,6 +55,7 @@ func resourceMongoDBAtlasThirdPartyIntegration() *schema.Resource { | |||
Required: true, | |||
ForceNew: true, | |||
ValidateFunc: validation.StringInSlice(integrationTypes, false), | |||
Deprecated: "This field type has values (NEW_RELIC, FLOWDOCK) that are deprecated and will be removed in 1.9.0 release ", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Deprecated
field marks the entire argument type
as deprecated, regardless of its value, which looks misleading to the user:
│ Warning: Argument is deprecated
│
│ with mongodbatlas_third_party_integration.atlas_datadog,
│ on <...>/mongodb-atlas-project/common/main.tf line 108, in resource "mongodbatlas_third_party_integration" "atlas_datadog":
│ 108: type = "DATADOG"
│
│ This field type has values (NEW_RELIC, FLOWDOCK) that are deprecated and
│ will be removed in 1.9.0 release
Probably, instead of the Deprecated
, it should be handled by the ValidateFunc
returning a warning in a certain case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened a new issue for that case: #1032
Description
Please include a summary of the fix/feature/change, including any relevant motivation and context.
Link to any related issue(s):
Type of change:
Required Checklist:
Further comments