Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTMDB-547: Enhance docs for mongodbatlas cloud_backup_schedule #1006

Conversation

edmallia
Copy link
Contributor

@edmallia edmallia commented Jan 16, 2023

Description

Updates documentation for mongodbatlas_cloud_backup_schedule by adding more information about possible values for frequency_type, frequency_interval, retention_unit and retention_value.

Fixes #1005 and INTMDB-547.

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

Branched off from master for the work done. Please advise if changes should be applied to a branch from v1.8.0_staging instead and PR recreated since there is other work in this PR.

Zuhairahmed and others added 13 commits January 2, 2023 19:03
…#1000)

* Add additional logging

* Add error handler exit for failed AWS STS areas

* Add error handler to get secret value
* Add additional logging

* Add error handler exit for failed AWS STS areas

* Add error handler to get secret value

* Add custom resolver for sts service add error handler for API key values

* Endpoint changes

* Add default URL for global sts
… more information about possible values for frequency_type, frequency_interval, retention_unit and retention_value.
… more information about possible values for frequency_type, frequency_interval, retention_unit and retention_value.
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some code changes that are not related to the documentation. Shouldn't this PR only change doc files?

@edmallia
Copy link
Contributor Author

@andreaangiolillo yes, hence my comment about whether the changes should be applied to a branch of v1.8.0_staging rather than master.

I have created new PR #1006 for work applied to a branch from v1.8.0_staging. PR #1006 includes only my changes.

@Zuhairahmed Zuhairahmed self-requested a review January 17, 2023 00:20
@Zuhairahmed
Copy link
Collaborator

Closing this PR as requested and going to review #1007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants