chore: Adds Github Actions linter (#1988)

* add actionlint * fix action linter issues * TEMPORARY: simulate mock changes * Revert "TEMPORARY: simulate mock changes" This reverts commit ed4cc68. * Update .github/workflows/code-health.yml Co-authored-by: Andrea Angiolillo <[email protected]> * Update .github/workflows/migration-tests.yml Co-authored-by: Andrea Angiolillo <[email protected]> --------- Co-authored-by: Andrea Angiolillo <[email protected]>
mongodb · Mar 5, 2024 · 619486b · 619486b
1 parent 42f04b1
commit 619486b
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/.github/workflows/code-health.yml b/.github/workflows/code-health.yml
@@ -24,11 +24,11 @@ jobs:
       run: make tools generate-mocks
     - name: Check for uncommited files
       run: |
-        export FILES=$(git ls-files -o -m --directory --exclude-standard --no-empty-directory)
-        export LINES=$(echo "$FILES" | awk 'NF' | wc -l)
-        if [ $LINES -ne 0 ]; then
+        FILES=$(git ls-files -o -m --directory --exclude-standard --no-empty-directory)
+        LINES=$(echo "$FILES" | awk 'NF' | wc -l)
+        if [ "${LINES}" -ne 0 ]; then
           echo "Detected files that need to be committed:"
-          echo "$FILES" | sed -e "s/^/  /"
+          echo "${FILES//^/ }"
           echo ""
           echo "Mock skeletons are not up-to-date, you may have forgotten to run mockery before committing your changes."
           exit 1
@@ -61,6 +61,11 @@ jobs:
         uses: golangci/golangci-lint-action@3cfe3a4abbb849e10058ce4af15d205b6da42804
         with:
           version: v1.56.2
+      - name: actionlint
+        run: | 
+          make tools 
+          actionlint -verbose -color
+        shell: bash  
   website-lint:
     runs-on: ubuntu-latest
     steps:

diff --git a/.github/workflows/migration-tests.yml b/.github/workflows/migration-tests.yml
@@ -47,7 +47,7 @@ jobs:
         run: |
          LAST_RELEASE=$(curl -sSfL -X GET https://api.github.com/repos/mongodb/terraform-provider-mongodbatlas/releases/latest | jq -r '.tag_name | ltrimstr("v")')
          echo "Last release: $LAST_RELEASE"
-         echo "last_provider_version=$LAST_RELEASE" >> $GITHUB_OUTPUT
+         echo "last_provider_version=${LAST_RELEASE}" >> "${GITHUB_OUTPUT}"
 
   change-detection:
     runs-on: ubuntu-latest

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -55,7 +55,9 @@ jobs:
           gpg_private_key: ${{ secrets.GPG_PRIVATE_KEY }}
           passphrase: ${{ secrets.PASSPHRASE }}
       - name: Set the user terminal
-        run: export GPG_TTY=$(tty)
+        run: | 
+          GPG_TTY=$(tty)
+          export GPG_TTY
       - name: Run GoReleaser
         uses: goreleaser/goreleaser-action@7ec5c2b0c6cdda6e8bbb49444bc797dd33d74dd8
         with: