update linter (#2307)

.github/workflows/code-health.yml

@@ -49,7 +49,7 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@a4f60bb28d35aeee14e6880718e0c85ff1882e64
         with:
-          version: v1.57.2
+          version: v1.59.0 # Also update GOLANGCI_VERSION variable in GNUmakefile when updating this version
       - name: actionlint
         run: make tools && actionlint -verbose -color
         shell: bash  

.golangci.yml

@@ -56,7 +56,7 @@ linters-settings:
   nestif:
     # minimal complexity of if statements to report, 5 by default
     min-complexity: 7
-  gomnd:
+  mnd:
     checks:
       - case
       - operation
@@ -74,7 +74,7 @@ linters:
     - gofmt
     - goimports
     - revive
-    - gomnd
+    - mnd
     - goprintffuncname
     - gosec
     - gosimple

GNUmakefile

@@ -17,7 +17,7 @@ GITTAG=$(shell git describe --always --tags)
 VERSION=$(GITTAG:v%=%)
 LINKER_FLAGS=-s -w -X 'github.com/mongodb/terraform-provider-mongodbatlas/version.ProviderVersion=${VERSION}'
 
-GOLANGCI_VERSION=v1.57.2
+GOLANGCI_VERSION=v1.59.0 # Also update golangci-lint GH action in code-health.yml when updating this version
 
 export PATH := $(shell go env GOPATH)/bin:$(PATH)
 export SHELL := env PATH=$(PATH) /bin/bash

internal/testutil/replay/hoverfly_setup.go

@@ -77,14 +77,14 @@ func cleanupCaptureMode(t *testing.T, port int) {
 }
 
 func randomPortNumber() int {
-	var min int64 = 1024
-	var max int64 = 65536
-	diff := max - min
+	var minPort int64 = 1024
+	var maxPort int64 = 65536
+	diff := maxPort - minPort
 	nBig, err := rand.Int(rand.Reader, big.NewInt(diff+1))
 	if err != nil {
 		log.Fatalf("Failed to generate random number: %v", err)
 	}
-	proxyPort := int(nBig.Int64() + min)
+	proxyPort := int(nBig.Int64() + minPort)
 	return proxyPort
 }