add requirement to error field #1729
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
requested changes
Nov 22, 2024
| the `error` field of the new `ServerDescription` object MUST include a descriptive error explaining that it was | ||
| invalidated because the primary was determined to be stale. Drivers MAY additionally specify whether this was due to an | ||
| electionId or setVersion mismatch. A multi-threaded client MUST | ||
| [request an immediate check](server-monitoring.md#requesting-an-immediate-check) for that server as soon as possible. |
There was a problem hiding this comment.
Should we expand the scope of this ticket to include more info in other cases where we reset a server to "unknown" besides stale primary?
| should be none or one) and replaces its description with a default ServerDescription of type "Unknown". Additionally, | ||
| the `error` field of the new `ServerDescription` object MUST include a descriptive error explaining that it was | ||
| invalidated because the primary was determined to be stale. Drivers MAY additionally specify whether this was due to an | ||
| electionId or setVersion mismatch. A multi-threaded client MUST |
There was a problem hiding this comment.
Let's get more specific about what the error should look like so that we can add tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please complete the following before merging:
clusters, and serverless).