Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing space before inline math #1718

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

mdbmes
Copy link
Contributor

@mdbmes mdbmes commented Nov 2, 2024

This fixes a Markdown rendering error in the client-side-encryption spec due to a typo. The problem was much more noticeable on GitHub than on mkdocs (readthedocs):

  • on GitHub, the word was no longer interpreted as math, and it rendered in plain text as "joining$dbName$"
  • on mkdocs the math markup rendered normally still, so it appeared as "joiningdbName" with "dbName" in math italics, making the missing space somewhat hard to see

@mdbmes mdbmes requested a review from a team as a code owner November 2, 2024 00:18
@mdbmes mdbmes requested review from katcharov and kevinAlbs and removed request for a team November 2, 2024 00:18
@blink1073
Copy link
Member

Yay, readthedocs preview in PRs is back!

@mdbmes mdbmes merged commit 21c1427 into mongodb:master Nov 5, 2024
5 checks passed
@mdbmes mdbmes deleted the cse-dbname-spc branch November 5, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants