DRIVERS-2865: Require drivers to always send out bypassDocumentValidation #1703
+724
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please complete the following before merging:
Test these changes against all server versions and topologies (including standalone, replica set, shardedclusters, and serverless).
This effectively reverts #266 and adds tests for the behaviour. I've also decided to remove the rationale for sending
bypassDocumentValidation: true
in the bulk write specification as this difference no longer exists.The new tests are grouped in a single file to make it easier for drivers to skip this particular test until they've had a chance to make the changes. No other test (aside client bulkWrite which already implements the new behaviour) use
bypassDocumentValidation: false
, so this change should not have any side effects in drivers.