DRIVERS-2124: test that inserts and upserts respect all _id values #1696
Conversation
nbbeeken
force-pushed
the
DRIVERS-2124-id-types
branch
2 times, most recently
from
b2bb775 to
ca4d811
Compare
nbbeeken
force-pushed
the
DRIVERS-2124-id-types
branch
from
ca4d811 to
fcd0a58
Compare
nbbeeken
changed the title
| tests: | ||
| - description: inserting _id with type double via insertOne | ||
| operations: | ||
| - {name: dropCollection, object: database, arguments: {collection: type_tests}} |
There was a problem hiding this comment.
Drop database and collection are expensive, slow commands. If we're adding so many tests it would be good to avoid it.
Also do we really need to test every combination of operation and BSON type?
There was a problem hiding this comment.
Perhaps it would be faster to put all the operations in one test? There's a lot of overhead to setting up a unified test which really adds up in runtime cost when adding 150 tests.
| @@ -31,8 +32,8 @@ jobs: | |||
| python3 ./source/client-side-encryption/etc/generate-test.py ./source/client-side-encryption/etc/test-templates/*.template ./source/client-side-encryption/tests/legacy | |||
| python3 ./source/client-side-operations-timeout/etc/generate-basic-tests.py ./source/client-side-operations-timeout/etc/templates ./source/client-side-operations-timeout/tests | |||
| python3 ./source/etc/generate-handshakeError-tests.py | |||
| node ./source/etc/generate-crud-id-type-tests.mjs | |||
There was a problem hiding this comment.
Nit: since all other scripts to generate test files are written in Python, should this one really be written in a different language?
There was a problem hiding this comment.
I wouldn't say no to php scripts :)
|
Thanks for the comments :) we're just going to test the null |
Please complete the following before merging:
clusters, and serverless).