-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRIVERS-1408 - Add guidance on adding _id fields to documents to CRUD spec #1688
Changes from 2 commits
2955d19
925cd95
1afe0c0
48ce014
e57594a
549ef56
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -737,3 +737,10 @@ that `firstEvent.operationId` is equal to `secondEvent.operationId`. Assert both | |
To force completion of the `w:0` writes, execute `coll.countDocuments` and expect the returned count is | ||
`maxMessageSizeBytes / maxBsonObjectSize + 1`. This is intended to avoid incomplete writes interfering with other tests | ||
that may use this collection. | ||
|
||
### 16. Generated document identifiers are the first field in their document | ||
alcaeus marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Construct a `MongoClient` (referred to as `client`) with | ||
[command monitoring](../../command-logging-and-monitoring/command-logging-and-monitoring.md) enabled to observe | ||
CommandStartedEvents. Perform an `insert` command using `client` and assert that one CommandStartedEvent (referred to as | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This is ambiguous, as the prose test could be implementing using the generic command runner, in which case I'd expect no ID generation. I'd suggest changing this to explicitly suggesting running an |
||
`event`) was observed, and that the first field of `event.command.documents[0]` is `_id`. | ||
nbbeeken marked this conversation as resolved.
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted that this is already discussed in the client bulk write spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having this behavior discussed here for general CRUD operations makes sense to me, as the client bulk write spec follows from this broader context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The client bulk write spec stands on its own, except for a reference back to CRUD for modeling unacknowledged write results.
With my last comment, I just meant to acknowledge that no changes were needed to the client bulk write spec since it already addressed
_id
ordering. This was in the vein of previous PRs like #1644 that required updates to both specs.