DRIVERS-2789 Convert Causal Consistency Spec to Markdown #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
requested review from
jmikola and
dariakp
and removed request for
a team and
dariakp
jmikola
approved these changes
Feb 9, 2024
| ## Reference Implementation | ||
|
|
||
| A reference implementation must be completed before any spec is given status "Final", but it need not be completed | ||
| before the spec is “Accepted”. While there is merit to the approach of reaching consensus on the specification and |
There was a problem hiding this comment.
Out-of-scope nit: if possible, I'd be in favor of a lint check to avoid curly quotes in spec files.
There was a problem hiding this comment.
I'm not aware of any such linter. :). I replaced them manually in this file.
| Note: some tests are only relevant to certain deployments. For the purpose of deciding which tests to run assume that | ||
| any deployment that is version 3.6 or higher and is either a replica set or a sharded cluster supports cluster times. | ||
|
|
||
| 01. When a `ClientSession` is first created the `operationTime` has no value. |
There was a problem hiding this comment.
This is the first time I've seen leading zeroes in spec sources. We can probably do without those.
|
|
||
| ### Terms | ||
|
|
||
| **Causal consistency**\ |
There was a problem hiding this comment.
Is this how you've been manually converting definition lists? Makes sense here, as it's probably the closest formatting we have to the RST.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please complete the following before merging:
clusters, and serverless).