Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-2789 Convert Auth Spec to Markdown #1501

Merged
merged 10 commits into from
Feb 7, 2024
Merged

DRIVERS-2789 Convert Auth Spec to Markdown #1501

merged 10 commits into from
Feb 7, 2024

Conversation

blink1073
Copy link
Member

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

@blink1073 blink1073 requested review from a team as code owners February 1, 2024 01:06
@blink1073 blink1073 requested review from JamesKovacs, jess-sig, baileympearson and matthewdale and removed request for a team, JamesKovacs, jess-sig and baileympearson February 1, 2024 01:06
matthewdale
matthewdale reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the content looks great! The numbered lists didn't convert correctly in many places. I made comments for some, but there are still some I didn't catch.

source/auth/tests/mongodb-aws.md Outdated Show resolved Hide resolved
source/auth/tests/mongodb-aws.md Outdated Show resolved Hide resolved
source/auth/auth.md Outdated Show resolved Hide resolved
source/auth/auth.md Outdated Show resolved Hide resolved
source/auth/auth.md Outdated Show resolved Hide resolved
source/auth/auth.md Outdated Show resolved Hide resolved
source/auth/auth.md Outdated Show resolved Hide resolved
source/auth/auth.md Outdated Show resolved Hide resolved
source/auth/auth.md Outdated Show resolved Hide resolved
@blink1073 blink1073 requested a review from a team as a code owner February 2, 2024 12:18
@blink1073 blink1073 requested review from matthewdale and removed request for a team February 2, 2024 12:37
@blink1073
Copy link
Member Author

cc @comandeo

matthewdale
matthewdale approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

source/auth/auth.md Outdated Show resolved Hide resolved
source/auth/auth.md Outdated Show resolved Hide resolved
source/auth/auth.md Outdated Show resolved Hide resolved
blink1073 and others added 3 commits February 5, 2024 13:27
@blink1073 blink1073 merged commit a5e5641 into mongodb:master Feb 7, 2024
4 checks passed
@blink1073 blink1073 deleted the DRIVERS-2789-auth branch February 7, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewdale matthewdale matthewdale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blink1073 @matthewdale