DRIVERS-2789 Convert Benchmarks Spec to Markdown #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
reviewed
Feb 6, 2024
source/benchmarking/benchmarking.md
Outdated
Comment on lines
651
to
655
| ## FAQ | ||
|
|
||
| Question? | ||
|
|
||
| Answer. |
There was a problem hiding this comment.
I feel like this is a good opportunity to remove this empty section.
source/benchmarking/benchmarking.md
Outdated
Comment on lines
168
to
169
| | | | | ||
| | ----------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | |
There was a problem hiding this comment.
This and all other tables here have an empty row at the top.
There was a problem hiding this comment.
Github Flavored Markdown doesn't support tables without headers
There was a problem hiding this comment.
I'll make up some headers. 😄
There was a problem hiding this comment.
Oh, I wasn't aware of that. Thanks for making up some headers!
alcaeus
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please complete the following before merging:
clusters, and serverless).