Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-2774 Delete pool-clear-interrupt-immediately #1487

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

stIncMale
Copy link
Member

@stIncMale stIncMale commented Jan 2, 2024

SDAM already have tests covering the functionality, for example,

- description: Connection pool clear uses interruptInUseConnections=true after monitor timeout
Given that currently pool-clear-interrupt-immediately cannot possibly work in Python and requires modifying the test runner, it seems better to remove the test.

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).

DRIVERS-2774

@stIncMale stIncMale requested a review from a team as a code owner January 2, 2024 18:16
@stIncMale stIncMale requested review from baileympearson and removed request for a team January 2, 2024 18:16
@stIncMale stIncMale self-assigned this Jan 2, 2024
@stIncMale stIncMale requested a review from ShaneHarvey January 2, 2024 18:17
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stIncMale stIncMale merged commit 9c122c8 into mongodb:master Jan 3, 2024
4 checks passed
@stIncMale stIncMale deleted the DRIVERS-2774 branch January 3, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants