-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRIVERS-1150 Writes are not retried within transactions #1481
DRIVERS-1150 Writes are not retried within transactions #1481
Conversation
Hi Dmitry, is there any background information for this change that you would be able to share with us on this PR? Also, does it make sense to have a test for this behavior? Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few suggestions, I don't need to do another round of review
@kkloberdanz I see the following comment on DRIVERS-1150:
This is a simple but important clarification for non-engineer audiences. It requires no driver changes or new tests.
Co-authored-by: Kyle Kloberdanz <[email protected]>
Co-authored-by: Isabel Atkinson <[email protected]>
Co-authored-by: Isabel Atkinson <[email protected]>
Co-authored-by: Isabel Atkinson <[email protected]>
Hi Kyle, as I understood the ticket, we just need to copy instructions from transactions spec to retryable writes spec. The behaviour is tested here |
Sounds good to me, I'll approve. |
Please complete the following before merging: