Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-1150 Writes are not retried within transactions #1481

Merged

Conversation

comandeo
Copy link

@comandeo comandeo commented Dec 6, 2023

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files - not applicable.
  • Test changes in at least one language driver - not applicable.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless) - not applicable.

@comandeo comandeo marked this pull request as ready for review December 6, 2023 14:57
@comandeo comandeo requested a review from a team as a code owner December 6, 2023 14:57
@comandeo comandeo requested review from kkloberdanz and removed request for a team December 6, 2023 14:57
@kkloberdanz
Copy link
Contributor

Hi Dmitry, is there any background information for this change that you would be able to share with us on this PR? Also, does it make sense to have a test for this behavior? Thank you.

Copy link
Contributor

@isabelatkinson isabelatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few suggestions, I don't need to do another round of review

@kkloberdanz I see the following comment on DRIVERS-1150:

This is a simple but important clarification for non-engineer audiences. It requires no driver changes or new tests.

source/retryable-writes/retryable-writes.rst Outdated Show resolved Hide resolved
source/retryable-writes/retryable-writes.rst Outdated Show resolved Hide resolved
source/retryable-writes/retryable-writes.rst Outdated Show resolved Hide resolved
@comandeo
Copy link
Author

Hi Dmitry, is there any background information for this change that you would be able to share with us on this PR? Also, does it make sense to have a test for this behavior? Thank you.

Hi Kyle, as I understood the ticket, we just need to copy instructions from transactions spec to retryable writes spec. The behaviour is tested here

@kkloberdanz
Copy link
Contributor

Hi Dmitry, is there any background information for this change that you would be able to share with us on this PR? Also, does it make sense to have a test for this behavior? Thank you.

Hi Kyle, as I understood the ticket, we just need to copy instructions from transactions spec to retryable writes spec. The behaviour is tested here

Sounds good to me, I'll approve.

@comandeo comandeo merged commit 1c40a03 into mongodb:master Dec 19, 2023
4 checks passed
@comandeo comandeo deleted the 1150-no-write-retries-in-transactions branch December 19, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants