-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRIVERS-2761 do not apply readConcern
or writeConcern
to search index commands
#1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
changed the title
DRIVERS-2761
DRIVERS-2761 do not apply Nov 8, 2023
readConcern
or writeConcern
to search index commands
baileympearson
approved these changes
Dec 7, 2023
GromNaN
approved these changes
Dec 11, 2023
vbabanin
reviewed
Dec 12, 2023
Aggregate with $listSearchIndexes accepts a `local` read concern. Use `majority` to ensure test fails if driver incorrectly applies read concern.
vbabanin
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
readConcern
andwriteConcern
is not applied to search index commands.Tests were run in the C++ driver in this PR: mongodb/mongo-cxx-driver#1055
Background & Motivation
This PR proposes adding tests to ensure each search index command does not include
readConcern
orwriteConcern
.Unit tests apply a non-default
readConcern
andwriteConcern
to the collection:Unit tests verify the command started event is checked:
The integration test is as an extra precaution to test against a live Atlas instance.
The C++ driver failed unit and integration tests prior to fixes applied in mongodb/mongo-cxx-driver#1055.
Please complete the following before merging: