DRIVERS-2695 Add a case of CSOT not enabled for the retryable writes. #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingyang-hu
requested review from
kkloberdanz and
ShaneHarvey
and removed request for
a team
ShaneHarvey
requested changes
Oct 11, 2023
| handleError(secondError); | ||
| throw secondError; | ||
| } | ||
| break |
There was a problem hiding this comment.
This doesn't account for NoWritesPerformed or error code 20. Is it possible to avoid duplicating the call to executeCommand and other logic here? Perhaps:
if ((timeoutMS == null && retrying) || (timeoutMS != null && isExpired(timeoutMS))) {
throw previousError;
}
retrying = True;
qingyang-hu
commented
Oct 16, 2023
| @@ -519,23 +520,15 @@ The above rules are implemented in the following pseudo-code: | |||
| if (timeoutMS == null) { | |||
There was a problem hiding this comment.
I have not merged the conditions to keep the reference code straightforward with the comments.
kkloberdanz
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please complete the following before merging:
Make sure there are generated JSON files from the YAML test files.Test changes in at least one language driver.Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).Driver changes are not needed.