DRIVERS-2616 OIDC-SASL Follow-Up #1460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My editor removed trailing white space, I recommend adding |
|
Tested in mongodb/mongo-python-driver#1365 |
addaleax
reviewed
Sep 5, 2023
source/auth/auth.rst
Outdated
| Before calling the callback, the driver MUST acquire a lock unique to the ``MongoClient``. | ||
| The driver MUST ensure that credentials have not changed between when the lock was requested and when it was acquired. The lock MUST be released | ||
| when the callback call as finished or errored. | ||
| This is because the ``REQUEST_TOKEN_CALLBACK`` may involve human interaction, and refresh tokens migh only be able to be used used once. |
There was a problem hiding this comment.
… but the only human-interaction workflow that currently exists doesn’t care about this lock.
I assume this also applies to machine workflows that perform work like HTTP calls?
There was a problem hiding this comment.
I'm deferring that conversation until DRIVERS-2672.
There was a problem hiding this comment.
Cool, sounds good to me 👍 Just saying, you could leave this out if you prefer to keep it simple until then. FFTR
Co-authored-by: Anna Henningsen <[email protected]>
Co-authored-by: Anna Henningsen <[email protected]>
addaleax
approved these changes
Sep 6, 2023
matthewdale
reviewed
Sep 19, 2023
Co-authored-by: Matt Dale <[email protected]>
durran
approved these changes
Sep 21, 2023
4 tasks
|
Closing since this will be merged with #1471 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please complete the following before merging: