chore(NODE-6493): CSOT clean ups and sync runCursorCommand test #4309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariakp
requested changes
Nov 1, 2024
test/unit/explain.test.ts
Outdated
| const cursor = new FindCursor( | ||
| new MongoClient('mongodb://localhost:27027'), | ||
| MongoDBNamespace.fromString('foo.bar'), | ||
| {}, | ||
| {} | ||
| ); | ||
|
|
||
| it('parseTimeoutOptions()', function () { | ||
| it('resolveExplainTimeoutOptions(no arguments)', function () { |
There was a problem hiding this comment.
as long as we're improving this, can we update all these to actually be meaningful? e.g. does not set timeout or explain when no arguments are provided, sets only timeout when only timeoutMS is provided
nbbeeken
force-pushed
the
chore-csot-cleanup
branch
from
804f996 to
4265508
Compare
|
I was able to unskip some of the tests that were marked with the closed cursor ticket, the two that are still skipped are related to the |
nbbeeken
changed the title
nbbeeken
added a commit
that referenced
this pull request
Nov 4, 2024
nbbeeken
added a commit
that referenced
this pull request
Nov 5, 2024
dariakp
pushed a commit
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Is there new documentation needed for these changes?
What is the motivation for this change?
Remaining cleanups for CSOT branch
Release Highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript