Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix resource management tests #4293

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

baileympearson
Copy link
Contributor

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the base branch from main to NODE-6090 October 25, 2024 15:53
@baileympearson baileympearson changed the title No story resource management chore: fix resource management tests Oct 25, 2024
@baileympearson baileympearson marked this pull request as ready for review October 25, 2024 15:56
@nbbeeken nbbeeken self-assigned this Oct 25, 2024
@nbbeeken nbbeeken merged commit 02215e6 into NODE-6090 Oct 25, 2024
11 of 14 checks passed
@nbbeeken nbbeeken deleted the no-story-resource-management branch October 25, 2024 16:18
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nbbeeken pushed a commit that referenced this pull request Nov 1, 2024
nbbeeken pushed a commit that referenced this pull request Nov 5, 2024
dariakp pushed a commit that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants