fix(NODE-6436): only force majority write concern on commitTransaction retry #4284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
durran
added
the
Primary Review
durran
requested changes
Oct 17, 2024
durran
approved these changes
Oct 17, 2024
durran
added
Team Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Ensure that
commitTransactiononly overrides the write concern when thecommitTransactioncall is retried (both with builtin retry mechanism and user-initiated retry).Is there new documentation needed for these changes?
No
What is the motivation for this change?
Needed by NODE-3914
Release Highlight
ClientSession.commitTransaction()no longer unconditionally overrides write concernPrior to this change,
ClientSession.commitTransaction()would always override any previously configuredwriteConcernon the initial attempt. This overriding behaviour now only applies to internal and user-initiated retries ofClientSession.commitTransaction()for a given transaction.Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript