-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix a few flaky CSOT tests #4278
Conversation
5e0f44b
to
25192e1
Compare
test/integration/client-side-operations-timeout/node_csot.test.ts
Outdated
Show resolved
Hide resolved
test/integration/client-side-operations-timeout/node_csot.test.ts
Outdated
Show resolved
Hide resolved
off by 1! should we expand the range? |
evergreen retry |
That's not behavior I'd ever expect - the killCursors is so slow that it usually takes an extra 5-7 hundred ms. I think we should leave this as-is, and if it continues to flake we should look into why it runs so much more quickly sometimes. That might be a bug in our CSOT logic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM, just seeing if I can clear the flakes, but will merge soon.
Description
What is changing?
I've noticed a number of flaky CSOT tests. This PR attempts to fix the flakiness.
Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript