Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix a few flaky CSOT tests #4278

Merged
merged 8 commits into from
Oct 17, 2024
Merged

chore: fix a few flaky CSOT tests #4278

merged 8 commits into from
Oct 17, 2024

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Oct 14, 2024

Description

What is changing?

I've noticed a number of flaky CSOT tests. This PR attempts to fix the flakiness.

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title asdf chore: fix a few flaky CSOT tests Oct 15, 2024
@baileympearson baileympearson marked this pull request as ready for review October 15, 2024 18:53
@nbbeeken nbbeeken self-assigned this Oct 15, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 15, 2024
@nbbeeken
Copy link
Contributor

                             Client Bulk Write
[2024/10/15 16:20:50.617]        CSOT enabled
[2024/10/15 16:20:50.617]          acknowledged writes
[2024/10/15 16:20:50.617]            when the timeout is reached while iterating the result cursor
[2024/10/15 16:20:50.617]              the bulk write operation times out:
[2024/10/15 16:20:50.617]      AssertionError: expected 1499 to be within 1500..2300

off by 1! should we expand the range?

@baileympearson
Copy link
Contributor Author

evergreen retry

@baileympearson
Copy link
Contributor Author

#4278 (comment)

That's not behavior I'd ever expect - the killCursors is so slow that it usually takes an extra 5-7 hundred ms. I think we should leave this as-is, and if it continues to flake we should look into why it runs so much more quickly sometimes. That might be a bug in our CSOT logic.

Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, just seeing if I can clear the flakes, but will merge soon.

@nbbeeken nbbeeken merged commit 00cb86b into NODE-6090 Oct 17, 2024
22 of 25 checks passed
@nbbeeken nbbeeken deleted the fix-flaky-tests branch October 17, 2024 19:18
nbbeeken pushed a commit that referenced this pull request Nov 1, 2024
nbbeeken pushed a commit that referenced this pull request Nov 5, 2024
dariakp pushed a commit that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants