fix(NODE-6412): read stale response from previously timed out connection #4273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
NODE-6090
branch
from
3591368 to
a645d9f
Compare
nbbeeken
force-pushed
the
NODE-6412-socket-timeout-v2
branch
from
a56bdd7 to
efbed5c
Compare
5 tasks
W-A-James
added
the
Primary Review
W-A-James
approved these changes
Oct 11, 2024
| `Timed out during socket read (${readError.duration}ms)` | ||
| ); | ||
| this.dataEvents = null; |
There was a problem hiding this comment.
Does this pretty much drop all packets that have been received but not read?
There was a problem hiding this comment.
Paraphrasing response from Slack
No, I am setting it to null because the iterator has already thrown the error, connection.cleanup will call
dataEvents.throw(error)if it exists, which it has already done because it was the one that threw
. This is just preventing us from doing the work twice.
Typically errors come from the socket, so dataEvents.throw(e) is how you get the for-await loop to "unblock"
. It's like you're inserting the error into the iterator, this new code path is coming out of the iterator, and entering clean up, so needs a new "null it out" line of code.
nbbeeken
added a commit
that referenced
this pull request
Oct 14, 2024
baileympearson
pushed a commit
that referenced
this pull request
Oct 21, 2024
nbbeeken
added a commit
that referenced
this pull request
Nov 1, 2024
nbbeeken
added a commit
that referenced
this pull request
Nov 5, 2024
dariakp
pushed a commit
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Is there new documentation needed for these changes?
No
What is the motivation for this change?
If the connection is not closed it will go back into the pool and a subsequent operation will read the reply to the previous operation
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript