Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(NODE-6398): bulkWrite internals to use async/await #4252

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

  • Refactor executeCommands to use async/await
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Stack traces, debugging

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken force-pushed the NODE-6398-callback-bulk branch from 7205846 to 11c6b10 Compare September 30, 2024 14:43
@nbbeeken nbbeeken marked this pull request as ready for review September 30, 2024 17:37
src/bulk/common.ts Show resolved Hide resolved
src/bulk/common.ts Show resolved Hide resolved
src/bulk/common.ts Show resolved Hide resolved
test/integration/crud/crud_api.test.ts Outdated Show resolved Hide resolved
src/bulk/unordered.ts Show resolved Hide resolved
src/bulk/common.ts Show resolved Hide resolved
src/bulk/common.ts Show resolved Hide resolved
@nbbeeken nbbeeken force-pushed the NODE-6398-callback-bulk branch from 11c6b10 to 595bf9f Compare October 7, 2024 17:45
@baileympearson baileympearson self-assigned this Oct 8, 2024
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 8, 2024
src/bulk/common.ts Show resolved Hide resolved
src/bulk/common.ts Show resolved Hide resolved
src/bulk/common.ts Show resolved Hide resolved
src/bulk/common.ts Show resolved Hide resolved
src/bulk/common.ts Outdated Show resolved Hide resolved
src/bulk/common.ts Outdated Show resolved Hide resolved
test/integration/crud/crud_api.test.ts Outdated Show resolved Hide resolved
@baileympearson baileympearson merged commit 8785132 into main Oct 9, 2024
30 checks passed
@baileympearson baileympearson deleted the NODE-6398-callback-bulk branch October 9, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants