-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-6304): Add CSOT support for non-tailable cursors #4195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W-A-James
commented
Aug 23, 2024
W-A-James
commented
Aug 23, 2024
W-A-James
commented
Aug 23, 2024
baileympearson
requested changes
Sep 10, 2024
baileympearson
approved these changes
Sep 12, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Sep 12, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Sep 25, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Sep 25, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Sep 27, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Sep 27, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Sep 27, 2024
baileympearson
pushed a commit
that referenced
this pull request
Oct 1, 2024
baileympearson
pushed a commit
that referenced
this pull request
Oct 1, 2024
W-A-James
added a commit
that referenced
this pull request
Oct 1, 2024
baileympearson
pushed a commit
that referenced
this pull request
Oct 10, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Oct 14, 2024
W-A-James
added a commit
that referenced
this pull request
Oct 14, 2024
baileympearson
pushed a commit
that referenced
this pull request
Oct 21, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Nov 1, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Nov 5, 2024
dariakp
pushed a commit
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Operations (direct user-facing changes)
timeoutMS
andtimeoutMode
to all cursor-creatingCollection
andDb
methods.Cursors
AbstractCursor
timeoutMS
andtimeoutMode
options to allAbstractCursor
CursorInitializeOptions
type and updatedAbstractCursor._initialize
to take this type as its options. Updated overrides of this type to match this signature and utilize the new options.timeoutContext
property toAbstractCursor
that is constructed insideAbstractCursor.cursorInit()
AbstractCursor.next()
,AbstractCursor.tryNext()
andAbstractCursor.hasNext()
timeoutMS
argument toAbstractCursor.close
and added CSOT timeout logic toAbstractCursor.cleanup
timeoutMS
argument toAbstractCursor.cleanup
maxTimeMS
field ongetMore
when CSOT is enabledAggregationCursor
$out
or$merge
stages are provided to anAggregationCursor
withtimeoutMode: ITERATION
ChangeStreamCursor
(note, this implementation is not complete. Will be finished in NODE-6305)_initialize
to make use of aformentionedCursorInitializeOptions
FindCursor
_initialize
to make use of aformentionedCursorInitializeOptions
ListCollectionsCursor
_initialize
to make use of aformentionedCursorInitializeOptions
ListIndexesCursor
_initialize
to make use of aformentionedCursorInitializeOptions
RunCommandCursor
_initialize
to make use of aformentionedCursorInitializeOptions
Timeout
andTimeoutContext
TimeoutContext.refresh()
method to reset active timeouts for cursor iteration and reuse aTimeoutContext
TimeoutContext.clear()
method to clear active timeouts associated with aTimeoutContext
Testing
ITERATION
andCURSOR_LIFETIME
modes work correctly for non-tailable cursorstimeoutMode
andtimeoutMS
options are passed through forrunCursorCommand
AggregationCursor
to ensure that$out
and$merge
helpers throw if inITERATION
modeIs there new documentation needed for these changes?
What is the motivation for this change?
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript