-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-5682): set maxTimeMS on commands and preempt I/O #4174
Merged
Merged
Changes from 20 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
a58ce34
feat(NODE-6090): Implement CSOT logic for connection checkout and ser…
W-A-James 7b4a1fb
test(NODE-6120): Implement Unified test runner changes for CSOT (#4121)
W-A-James 3f4313e
feat(NODE-6090): Implement CSOT logic for connection checkout and ser…
W-A-James 4aa6575
refactor(NODE-6187): refactor to use TimeoutContext abstraction (#4131)
W-A-James 898b93f
refactor(NODE-6230): executeOperation to use iterative retry mechanis…
W-A-James 6125789
WIP maxTimeMS
nbbeeken 749ad6d
chore: rm stack trace
nbbeeken e7dec00
pass timeoutMS to runCommand
W-A-James 8d83bf5
wrap errors correctly
W-A-James 74ae021
throw MongoOperationTimeoutError instead of TimeoutError
W-A-James 59eb1b1
pass timeoutContext through to Connection.command
W-A-James ad90766
remove unused field
W-A-James 6f9925c
don't ejsonify logs
W-A-James a432320
pass timeoutMS through to listDatabases
W-A-James f897155
Remove Error.captureStackTrace calls
W-A-James edf63e4
unskip tests
W-A-James 7c79517
fix: connect ignores timeoutMS setting from client
nbbeeken 2fb3226
chore: unset timeoutMS not 0
nbbeeken 9ee5112
test: skip more connect tests
nbbeeken f5f9bc9
chore: add ticket
nbbeeken 2fdeab8
comments 1
nbbeeken 520fc51
chore: move socket timeouts into method
nbbeeken 89ddaae
chore: move start
nbbeeken 5e975d7
chore: linttttttttttttttttttttttttttttttttttttttttttttttt
nbbeeken File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused why this logic is necessary - if the remaining timeoutMS is less than minRoundTripTime, we're supposed to throw and exit. So maxTimeMS should never be negative here - right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, but this is a check for greater than 0, so it confirms that maxTimeMS does not equal 0. The checks for if we should throw are colocated with the write/read steps.