Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(NODE-6230): executeOperation to use iterative retry mechanism #4157

Merged
merged 14 commits into from
Jun 27, 2024
Merged

refactor(NODE-6230): executeOperation to use iterative retry mechanism #4157

merged 14 commits into from
Jun 27, 2024

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Jun 21, 2024 •
edited
Loading

Description

What is changing?

  • Refactor executeOperation to use iterative retry mechanism
  • Replaced retryOperation helper function with executeOperationWithRetry helper function
  • Changed AbstractOperation's canRetryWrite and canRetryRead getter methods to use opeation aspects as source of truth for retryability instead of defaulting to true for both (note that these values are being relied upon in executeOperation in a different manner than prior to the refactor so the inconsistency that existed prior did not affect correctness before, but had to be updated to ensure correctness here)
  • Changed CommandOperation's canRetryWrite getter to fallback on the parent class' value of canRetryWrite
Is there new documentation needed for these changes?
  • No

What is the motivation for this change?

NODE-6230

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James marked this pull request as ready for review June 26, 2024 19:43
@nbbeeken nbbeeken self-assigned this Jun 26, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 26, 2024
@nbbeeken nbbeeken self-requested a review June 26, 2024 19:45
nbbeeken
nbbeeken approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jun 26, 2024
@nbbeeken nbbeeken changed the title refactor(NODE-6230): Refactor executeOperation to use iterative retry mechanism refactor(NODE-6230): executeOperation to use iterative retry mechanism Jun 27, 2024
@nbbeeken nbbeeken merged commit e5b80ec into NODE-6090 Jun 27, 2024
26 checks passed
@nbbeeken nbbeeken deleted the NODE-6230 branch June 27, 2024 11:45
W-A-James added a commit that referenced this pull request Jul 2, 2024
@W-A-James
refactor(NODE-6230): executeOperation to use iterative retry mechanism (
96bb929 
#4157)
@nbbeeken nbbeeken mentioned this pull request Jul 2, 2024
Merged
5 tasks
W-A-James added a commit that referenced this pull request Jul 8, 2024
@W-A-James
refactor(NODE-6230): executeOperation to use iterative retry mechanism (
58d4e7b 
#4157)
nbbeeken pushed a commit that referenced this pull request Jul 11, 2024
@W-A-James @nbbeeken
refactor(NODE-6230): executeOperation to use iterative retry mechanism (
37f31b8 
#4157)
nbbeeken added a commit that referenced this pull request Jul 22, 2024
@nbbeeken
refactor(NODE-6230): executeOperation to use iterative retry mechanism (
5759f72 
#4157)
nbbeeken pushed a commit that referenced this pull request Jul 22, 2024
@W-A-James @nbbeeken
refactor(NODE-6230): executeOperation to use iterative retry mechanism (
898b93f 
#4157)
nbbeeken added a commit that referenced this pull request Aug 13, 2024
@nbbeeken
refactor(NODE-6230): executeOperation to use iterative retry mechanism (
f85cb03 
#4157)
nbbeeken added a commit that referenced this pull request Aug 20, 2024
@nbbeeken
refactor(NODE-6230): executeOperation to use iterative retry mechanism (
26800a9 
#4157)
nbbeeken added a commit that referenced this pull request Aug 21, 2024
@nbbeeken
refactor(NODE-6230): executeOperation to use iterative retry mechanism (
c5969b2 
#4157)
nbbeeken added a commit that referenced this pull request Sep 12, 2024
@nbbeeken
refactor(NODE-6230): executeOperation to use iterative retry mechanism (
e4efd3f 
#4157)
nbbeeken added a commit that referenced this pull request Sep 25, 2024
@nbbeeken
refactor(NODE-6230): executeOperation to use iterative retry mechanism (
7139b8f 
#4157)
nbbeeken added a commit that referenced this pull request Sep 27, 2024
@nbbeeken
refactor(NODE-6230): executeOperation to use iterative retry mechanism (
e59e632 
#4157)
baileympearson pushed a commit that referenced this pull request Oct 1, 2024
@nbbeeken @baileympearson
refactor(NODE-6230): executeOperation to use iterative retry mechanism (
c0dd1ca 
#4157)
baileympearson pushed a commit that referenced this pull request Oct 1, 2024
@nbbeeken @baileympearson
refactor(NODE-6230): executeOperation to use iterative retry mechanism (
3051def 
#4157)
baileympearson pushed a commit that referenced this pull request Oct 10, 2024
@nbbeeken @baileympearson
refactor(NODE-6230): executeOperation to use iterative retry mechanism (
0a23f20 
#4157)
nbbeeken added a commit that referenced this pull request Oct 14, 2024
@nbbeeken
refactor(NODE-6230): executeOperation to use iterative retry mechanism (
398066e 
#4157)
baileympearson pushed a commit that referenced this pull request Oct 21, 2024
@nbbeeken @baileympearson
refactor(NODE-6230): executeOperation to use iterative retry mechanism (
20b1040 
#4157)
nbbeeken added a commit that referenced this pull request Nov 1, 2024
@nbbeeken
refactor(NODE-6230): executeOperation to use iterative retry mechanism (
fe70532 
#4157)
nbbeeken added a commit that referenced this pull request Nov 5, 2024
@nbbeeken
refactor(NODE-6230): executeOperation to use iterative retry mechanism (
e7d4494 
#4157)
dariakp pushed a commit that referenced this pull request Nov 6, 2024
@nbbeeken @dariakp
refactor(NODE-6230): executeOperation to use iterative retry mechanism (
195b3ad 
#4157)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@W-A-James @nbbeeken